CB-5625 Show only enabled identity providers in configuration section #2927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oviders in checkbox
devnaumov
previously requested changes
Sep 20, 2024
|
|
||
| export type AuthProvider = NonNullable<AuthProviderInfoFragment>; | ||
| export type AuthProviderConfiguration = NonNullable<AuthProviderConfigurationInfoFragment>; | ||
|
|
||
| @injectable() | ||
| export class AuthProvidersResource extends CachedMapResource<string, AuthProvider> { | ||
| get configurable(): AuthProvider[] { | ||
| return this.values.filter(provider => provider.configurable); | ||
| const enabledAuthProviders = new Set(this.serverConfigResource.enabledAuthProviders); |
There was a problem hiding this comment.
We dont want this logic in resource, please move it to the plugin-identity-providers-administration and filter on the component level, also we want to show some placeholder (we need to thing about the ui) if there is no available providers
… auth providers in checkbox" This reverts commit 4b2ac99.
…s-in-configuration-section
…s-in-configuration-section
Wroud
requested changes
Sep 25, 2024
webapp/packages/core-authentication/src/AuthProvidersResource.ts
Outdated
Show resolved
Hide resolved
…s-in-configuration-section
Wroud
reviewed
Sep 25, 2024
Wroud
approved these changes
Sep 26, 2024
…s-in-configuration-section
…s-in-configuration-section
Wroud
requested changes
Sep 26, 2024
…s-in-configuration-section
…s-in-configuration-section
Wroud
approved these changes
Sep 27, 2024
Wroud
deleted the
CB-5625-show-only-enabled-identity-providers-in-configuration-section
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.