Cb 4661 remove includes concept from resources api #2910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from connections feature
Wroud
requested changes
Sep 16, 2024
webapp/packages/core-authentication/src/TeamInfoMetaParametersResource.ts
Show resolved
Hide resolved
webapp/packages/core-authentication/src/TeamInfoMetaParametersResource.ts
Outdated
Show resolved
Hide resolved
webapp/packages/core-authentication/src/UserInfoMetaParametersResource.ts
Outdated
Show resolved
Hide resolved
webapp/packages/core-authentication/src/UserInfoMetaParametersResource.ts
Outdated
Show resolved
Hide resolved
Wroud
requested changes
Sep 18, 2024
webapp/packages/core-authentication/src/TeamInfoMetaParametersResource.ts
Outdated
Show resolved
Hide resolved
webapp/packages/core-authentication/src/UsersOriginDetailsResource.ts
Outdated
Show resolved
Hide resolved
webapp/packages/core-connections/src/ConnectionInfoOriginResource.ts
Outdated
Show resolved
Hide resolved
webapp/packages/core-sdk/src/queries/fragments/DatabaseConnectionOrigin.gql
Outdated
Show resolved
Hide resolved
webapp/packages/core-sdk/src/queries/fragments/DatabaseConnectionOriginDetails.gql
Outdated
Show resolved
Hide resolved
webapp/packages/core-connections/src/ConnectionInfoOriginResource.ts
Outdated
Show resolved
Hide resolved
webapp/packages/core-connections/src/ConnectionInfoOriginDetailsResource.ts
Outdated
Show resolved
Hide resolved
devnaumov
reviewed
Sep 18, 2024
| status.info('administration_teams_team_info_created'); | ||
| status.info(team.teamId); | ||
| } else { | ||
| const team = await this.teamResource.updateTeam(config); | ||
| const [team] = await Promise.all([ |
There was a problem hiding this comment.
I think here we dont want to run these mutations in parallel as we dont want to set parameters if we failed to update the team
There was a problem hiding this comment.
nice one! thanks
| @@ -25,6 +25,14 @@ export const ConnectionsTable = observer<Props>(function ConnectionsTable({ stat | |||
| const projectService = useService(ProjectsService); | |||
| const dbDriverResource = useResource(ConnectionsTable, DBDriverResource, CachedMapAllKey); | |||
| const shouldDisplayProjects = projectService.activeProjects.filter(project => isGlobalProject(project) || isSharedProject(project)).length > 1; | |||
| const connectionOriginResource = useResource(ConnectionsTable, ConnectionInfoOriginResource, CachedMapAllKey); | |||
| const connectionOriginsMap: Map<string, ConnectionInfoOrigin> = connectionOriginResource.data.reduce((acc, origin) => { | |||
Wroud
approved these changes
Sep 18, 2024
| const originLocal = !info || (originInfo && isLocalConnection(originInfo)); | ||
| const originLocal = !info || (originInfo?.origin && isLocalConnection(originInfo.origin)); |
There was a problem hiding this comment.
isLocalConnection can accepts origin | undefined (in case property origin can be undefined / null)
There was a problem hiding this comment.
After the new changes now it is not able to pass null or undefined
…ection" This reverts commit 4e57ce5.
Wroud
approved these changes
Sep 23, 2024
Wroud
deleted the
CB-4661-remove-includes-concept-from-resources-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.