-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-5578 DM: Ability to remove custom certificate #2899
Merged
Merged
Changes from 30 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
6546249
CB-5578 handles url for redirect after custom domain is being deleted
sergeyteleshev 7a08dcd
CB-5578 reverts isValidUrl
sergeyteleshev 1d262ce
CB-5578 pr fixes
sergeyteleshev 9f503c6
Merge branch 'devel' into CB-5578-dm-ability-to-remove-custom-certifi…
kseniaguzeeva 974cf4f
Merge branch 'devel' into CB-5578-dm-ability-to-remove-custom-certifi…
kseniaguzeeva 27a6137
CB-5578 fixes for QA
sergeyteleshev 2b9fa0e
Merge branch 'devel' into CB-5578-dm-ability-to-remove-custom-certifi…
sergeyteleshev 6d3eddd
Merge branch 'devel' into CB-5578-dm-ability-to-remove-custom-certifi…
sergeyteleshev 04fbe91
Merge branch 'devel' into CB-5578-dm-ability-to-remove-custom-certifi…
sergeyteleshev 60c543e
CB-5578 fixes for redirect on server url in custom certificate deletion
sergeyteleshev c3306b4
Merge branch 'devel' into CB-5578-dm-ability-to-remove-custom-certifi…
sergeyteleshev b27b153
CB-5578 fix import
sergeyteleshev 897ea42
CB-5578 creates isValidServer file
sergeyteleshev 1f537bb
CB-5578 allow any protocol server url but redirect on https only
sergeyteleshev ec36317
CB-5578 fix error message in details popup
sergeyteleshev fc9305e
Merge remote-tracking branch 'origin/devel' into CB-5578-dm-ability-t…
yagudin10 2eb78a6
СB-removes unneeded tranlsation
sergeyteleshev 3d4ed40
CB-5578 pr fixes
sergeyteleshev 6fb0691
Merge branch 'devel' into CB-5578-dm-ability-to-remove-custom-certifi…
sergeyteleshev 27bdb2a
Merge branch 'devel' into CB-5578-dm-ability-to-remove-custom-certifi…
sergeyteleshev 67b71ff
Merge branch 'devel' into CB-5578-dm-ability-to-remove-custom-certifi…
sergeyteleshev 7ecb695
CB-5578 dm fix for deletion of custom certificate
sergeyteleshev cec5b98
CB-5578 fix get https url helper
sergeyteleshev 6a47f6f
CB-5578 cleanup
sergeyteleshev 115053e
Merge branch 'devel' into CB-5578-dm-ability-to-remove-custom-certifi…
EvgeniaBzzz 72af51a
Merge branch 'devel' into CB-5578-dm-ability-to-remove-custom-certifi…
kseniaguzeeva 963a24e
Merge branch 'devel' into CB-5578-dm-ability-to-remove-custom-certifi…
sergeyteleshev 2c6be4c
Merge branch 'devel' into CB-5578-dm-ability-to-remove-custom-certifi…
sergeyteleshev 5eb9105
CB-5578 adds status message for custom certificate deletion
sergeyteleshev 9ef3694
CB-5578 sends server url without protocol while custom certificate de…
sergeyteleshev 7f58d3f
CB-5578 pr fixes
sergeyteleshev 5d83b3a
CB-5578 adds loader to the deletion of custom certificate
sergeyteleshev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
/* | ||
* CloudBeaver - Cloud Database Manager | ||
* Copyright (C) 2020-2024 DBeaver Corp and others | ||
* | ||
* Licensed under the Apache License, Version 2.0. | ||
* you may not use this file except in compliance with the License. | ||
*/ | ||
export function removeProtocolFromUrl(url: string): string { | ||
return url.replace(/(^\w+:|^)\/\//, ''); | ||
} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use
new URL(url).origin
?do we really need this helper function?