Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-5337 fixes checkbox background color #2777

Conversation

sergeyteleshev
Copy link
Contributor

No description provided.

@sergeyteleshev sergeyteleshev self-assigned this Jul 12, 2024
Comment on lines 61 to 66
.theme-checkbox_on_surface {
$mdc-checkbox-mark-color: $mdc-theme-primary;
@include mdc-checkbox-ink-color($mdc-checkbox-mark-color, $query);
@include mdc-checkbox-disabled-ink-color(rgba($mdc-checkbox-mark-color, 0.5), $query);
@include mdc-checkbox-container-colors($mdc-theme-on-surface, transparent, $mdc-theme-on-surface, $mdc-theme-on-surface);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix theme-checkbox_surface style instead

@sergeyteleshev sergeyteleshev requested a review from Wroud July 12, 2024 13:32
@Wroud
Copy link
Member

Wroud commented Jul 16, 2024

will be fixed in another PR

@Wroud Wroud closed this Jul 16, 2024
@Wroud Wroud deleted the CB-5337-fix-checkboxes-view-in-the-dark-theme-in-the-top-toolbar branch July 16, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants