CB-4961 Control files downloading ability #2744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wroud
requested changes
Jun 27, 2024
webapp/packages/plugin-data-viewer/src/DataViewerSettingsService.ts
Outdated
Show resolved
Hide resolved
Wroud
requested changes
Jun 27, 2024
| @@ -42,6 +43,7 @@ export class ResultSetDataContentAction extends DatabaseDataAction<any, IDatabas | |||
| private readonly graphQLService: GraphQLService, | |||
| private readonly quotasService: QuotasService, | |||
| private readonly cache: ResultSetCacheAction, | |||
| private readonly dataViewerService: DataViewerService, | |||
There was a problem hiding this comment.
this is not responsibility of database data model - it presents only database not hight level API or logic
Wroud
approved these changes
Jun 28, 2024
|
please fix unit tests |
|
I removed unit test cause moved the setting to |
|
|
devnaumov
approved these changes
Jun 28, 2024
devnaumov
reviewed
Jul 1, 2024
...packages/plugin-data-viewer/src/ValuePanelPresentation/ImageValue/ImageValuePresentation.tsx
Outdated
Show resolved
Hide resolved
Wroud
requested changes
Jul 1, 2024
webapp/packages/plugin-data-viewer/src/DataViewerSettingsService.ts
Outdated
Show resolved
Hide resolved
webapp/packages/plugin-data-viewer/src/DataViewerSettingsService.ts
Outdated
Show resolved
Hide resolved
|
please fix tests |
Wroud
approved these changes
Jul 1, 2024
Wroud
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.