Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-5181 Display User Notification Pop-up When Copy/Paste Functionality is Disabled by Administrator #2730

Conversation

sergeyteleshev
Copy link
Contributor

No description provided.

@sergeyteleshev sergeyteleshev self-assigned this Jun 24, 2024
Copy link
Member

@Wroud Wroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like copy data from the table is not covered by this PR

@@ -50,6 +50,8 @@ export default [
['data_viewer_total_count_canceled_message', 'Statement was cancelled due to user request'],
['data_viewer_total_count_failed', 'Failed to get total count'],
['data_viewer_model_not_loaded', 'Table model is not loaded'],
['data_viewer_copy_not_allowed', 'An ability to copy data is disabled'],
['data_viewer_copy_not_allowed_message', 'Please allow the "Preferences" to change it or ask your admin'],
Copy link
Member

@devnaumov devnaumov Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If its an admin, he always can copy data, so no need to mention preferences here, i would suggest remove message completely or rephrase it like this: "If this is unexpected, contact the administrator"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text was required by the ticket

@Wroud Wroud merged commit 4842cba into devel Jun 25, 2024
7 checks passed
@Wroud Wroud deleted the CB-5181-display-user-notification-pop-up-when-copy-paste-functionality-is-disabled-by-administrator branch June 25, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants