Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CB-4868 extend editor highlight #2647

Merged
merged 7 commits into from
May 23, 2024
Merged

CB-4868 extend editor highlight #2647

merged 7 commits into from
May 23, 2024

Conversation

devnaumov
Copy link
Member

No description provided.

@devnaumov devnaumov requested review from Wroud and sergeyteleshev May 21, 2024 10:52
@devnaumov devnaumov self-assigned this May 21, 2024
Wroud
Wroud requested changes May 21, 2024
View reviewed changes
Copy link
Member

@Wroud Wroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add tok-labelName, tok-className and tok-punctuation seems to be too contrast, maybe we can use different color (not black)
and also tok-atom has wrong contrast in black theme

@Wroud Wroud merged commit 0957684 into devel May 23, 2024
3 checks passed
@Wroud Wroud deleted the CB-4868-syntax-highlight branch May 23, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyteleshev sergeyteleshev sergeyteleshev approved these changes

@Wroud Wroud Wroud approved these changes

Assignees

@devnaumov devnaumov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devnaumov @Wroud @sergeyteleshev @EvgeniaBzzz