CB-4841 fix: concurrent tree update #2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyteleshev
approved these changes
Apr 10, 2024
| @@ -170,98 +169,96 @@ export function useElementsTree(options: IOptions): IElementsTree { | |||
| return false; | |||
| } | |||
| } | |||
| const [loadingNodes] = useState(() => observable.map(new Map<string, Promise<void>>(), { deep: false })); | |||
There was a problem hiding this comment.
I think we should move it to elementsTree state as observable.shallow to keep all trees tools in one place
| } | ||
| return; | ||
| async loadTree(...nodes: string[]) { | ||
| await Promise.all(loadingNodes.values()); |
There was a problem hiding this comment.
I suppose we can move it a little bit down in order to preload all resources first and when all data is being fresh we can start working with upcoming tree nodes
devnaumov
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.