Cb 4548 sql editor resultsets can be closed one by one only when execute sql statement has been used for several queries #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyteleshev
commented
Mar 26, 2024
| @@ -58,14 +58,25 @@ export const SqlResultTabs = observer<Props>(function SqlDataResult({ state, onT | |||
| } | |||
|
|
|||
| async function handleClose(tab: ITabData) { | |||
| const canClose = await sqlResultTabsService.canCloseResultTab(state, tab.tabId); | |||
| const canClose = handleCanClose(tab); | |||
There was a problem hiding this comment.
this is the fix of the ticket. the rest is about adding new action
Wroud
requested changes
Mar 27, 2024
Wroud
requested changes
Mar 27, 2024
webapp/packages/plugin-sql-editor-navigation-tab/src/SqlEditorBootstrap.ts
Outdated
Show resolved
Hide resolved
webapp/packages/plugin-sql-editor-navigation-tab/src/ACTION_TAB_CLOSE_GROUP.ts
Outdated
Show resolved
Hide resolved
webapp/packages/plugin-sql-editor-navigation-tab/src/SqlEditorBootstrap.ts
Outdated
Show resolved
Hide resolved
Wroud
approved these changes
Mar 27, 2024
…-one-by-one-only-when-execute-sql-statement-has-been-used-for-several-queries
…-one-by-one-only-when-execute-sql-statement-has-been-used-for-several-queries
Wroud
requested changes
Mar 28, 2024
webapp/packages/plugin-sql-editor/src/SqlEditorGroupTabsBootstrap.ts
Outdated
Show resolved
Hide resolved
…-one-by-one-only-when-execute-sql-statement-has-been-used-for-several-queries
…ghlight tab logic)
Wroud
requested changes
Mar 29, 2024
webapp/packages/plugin-sql-editor/src/SqlResultTabs/SqlResultTabsService.ts
Outdated
Show resolved
Hide resolved
webapp/packages/plugin-sql-editor/src/SqlEditorGroupTabsBootstrap.ts
Outdated
Show resolved
Hide resolved
Wroud
approved these changes
Mar 29, 2024
devnaumov
requested changes
Apr 2, 2024
webapp/packages/plugin-sql-editor/src/SqlResultTabs/SqlResultTabs.tsx
Outdated
Show resolved
Hide resolved
devnaumov
approved these changes
Apr 2, 2024
serge-rider
deleted the
CB-4548-sql-editor-resultsets-can-be-closed-one-by-one-only-when-execute-sql-statement-has-been-used-for-several-queries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.