CB-4222 feat: read blob data for value panel #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnaumov
reviewed
Feb 28, 2024
webapp/packages/plugin-data-viewer/src/ValuePanelPresentation/TextValue/useTextValue.ts
Show resolved
Hide resolved
| if (isResultSetBlobValue(this.cellValue)) { | ||
| // uploaded file preview | ||
| return URL.createObjectURL(this.cellValue.blob); | ||
| return this.cellValue.blob; | ||
| } | ||
|
|
||
| if (this.staticSrc) { |
There was a problem hiding this comment.
probably we want this condition to be at the end of the function
so if we have some blobs cached we return it first
and only then if there are nothing to give from cache we can give a link to download
There was a problem hiding this comment.
priority is:
- changed value (preview)
- available src data (we don't need to have cache in this case)
- available cache if src is not available
| () => ({ | ||
| observedValueMetadata: new Map(), | ||
|
|
||
| observedValue<TArgs, TValue>(key: string, args: () => TArgs, loader: (args: TArgs) => Promise<TValue>): () => TValue { |
There was a problem hiding this comment.
we can consider the key argument to be a symbol, not a string. to avoid collisions when the same key can has 2 different values depending on context where it was called
There was a problem hiding this comment.
there is no difference because the main problem is that the same component can be mounted more than 1 time and will use the same key (no matter the type)
sergeyteleshev
approved these changes
Feb 29, 2024
devnaumov
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.