CB-4681 fix: content downloading in value panel #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cause we can now see image presentation for Blob which are not images in ValuePanel |
sergeyteleshev
requested changes
Feb 26, 2024
...packages/plugin-data-viewer/src/ValuePanelPresentation/ImageValue/ImageValuePresentation.tsx
Outdated
Show resolved
Hide resolved
...packages/plugin-data-viewer/src/ValuePanelPresentation/ImageValue/ImageValuePresentation.tsx
Outdated
Show resolved
Hide resolved
sergeyteleshev
approved these changes
Feb 27, 2024
| @@ -165,69 +149,81 @@ export class ResultSetDataContentAction extends DatabaseDataAction<any, IDatabas | |||
|
|
|||
There was a problem hiding this comment.
async getFileDataUrl(element: IResultSetElementKey) {
lets make this function private. it is not in use outside of this action scope. moreover, it is easy to mess up with logic:
- use it outside to get link
- forget to put cached link into the cache so we can use it
- have a bug somewhere
| } | ||
| }); | ||
|
|
||
| return url; | ||
| } | ||
|
|
||
| async resolveFileDataUrl(element: IResultSetElementKey) { | ||
| const cachedUrl = this.retrieveFileDataUrlFromCache(element); | ||
| const cachedUrl = this.retrieveBlobFromCache(element); | ||
|
|
||
| if (cachedUrl) { | ||
| return cachedUrl; | ||
| } | ||
|
|
||
| const url = await this.getFileDataUrl(element); |
There was a problem hiding this comment.
this function sets cache loading state as expects
but we have a somekind of freeze in view button cause const blob = await downloadFromURL(url); below is not handled with loader, I suppose
I've send you the video
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.