CB-4561 te UI dynamic connection credentials based on the users team #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c-connection-credentials-based-on-the-users-team
…c-connection-credentials-based-on-the-users-team
…c-connection-credentials-based-on-the-users-team
Wroud
force-pushed
the
CB-4561-te-ui-dynamic-connection-credentials-based-on-the-users-team
branch
from
601ac75 to
d321a87
Compare
…s-based-on-the-users-team
…c-connection-credentials-based-on-the-users-team
…c-connection-credentials-based-on-the-users-team
devnaumov
approved these changes
Feb 15, 2024
| readonly, | ||
| disabled, | ||
| }) { | ||
| if (!properties) { |
There was a problem hiding this comment.
Probably properties is not an optional field then?
| items={availableAuthModels} | ||
| keySelector={model => model!.id} | ||
| valueSelector={model => model!.displayName} | ||
| titleSelector={model => model?.description} |
There was a problem hiding this comment.
Seems like the model is defined here and we dont need ?. here
There was a problem hiding this comment.
added isNotNullDefined filter
| ...connectionKey, | ||
| selectedSecretId: secretId, | ||
| }); | ||
| state.exception = null; |
There was a problem hiding this comment.
probably we want to set exception to null before we try to init connection?
There was a problem hiding this comment.
actually it doesn't matter here because we will hide exception message while connecting
| @@ -19,4 +19,8 @@ export default [ | |||
| ['settings_connections_hide_connections_view_description', 'Показывать подключения только администраторам'], | |||
|
|
|||
| ['connections_public_connection_ssl_enable', 'Включить SSL'], | |||
|
|
|||
| ['plugin_connections_connection_form_shared_credentials_manage_info', 'Вы можете указать учетные данные в '], | |||
| ['plugin_connections_connection_form_shared_credentials_manage_info_tab_link', 'табе "Учетные данные"'], | |||
serge-rider
deleted the
CB-4561-te-ui-dynamic-connection-credentials-based-on-the-users-team
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.