Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-4605 fix: sql editor shows datasets panels correctly #2347

Merged
merged 10 commits into from
Feb 5, 2024
Merged

CB-4605 fix: sql editor shows datasets panels correctly #2347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5e2afc5
CB-4605 fix: sql editor shows datasets panels correctly
Jan 31, 2024
1340b55
Revert "CB-4605 fix: sql editor shows datasets panels correctly"
Feb 1, 2024
8cd12e4
CB-4605 fix: TE edit dataset works fine with new dividers
Feb 1, 2024
49fa5da
CB-4605 revert sqleditor displayed editors state
Feb 1, 2024
7ad98e4
CB-4605 removed sqlEditor hack to open full size dataset
Feb 1, 2024
8cf8ec4
Revert "CB-4605 removed sqlEditor hack to open full size dataset"
Feb 1, 2024
e0aa4b3
CB-4605 sqlEditor works as it was for EE and TE
Feb 1, 2024
66b84c5
Merge branch 'devel' into CB-4605-te-datasets-blank-field-when-openin…
EvgeniaBzzz Feb 5, 2024
a94de3f
Merge branch 'devel' into CB-4605-te-datasets-blank-field-when-openin…
EvgeniaBzzz Feb 5, 2024
b32e65f
Merge branch 'devel' into CB-4605-te-datasets-blank-field-when-openin…
Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions webapp/packages/plugin-sql-editor/src/SqlEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@ export const SqlEditor = observer<Props>(function SqlEditor({ state }) {
<Loader suspense>
<CaptureView className={s(styles, { captureView: true })} view={sqlEditorView}>
<Split {...splitState} split="horizontal" sticky={30}>
<Pane className={s(styles, { pane: true })}>
<Pane className={s(styles, { pane: true })} basis="50%" main>
<SqlEditorLoader state={state} />
</Pane>
<ResizerControls />
<Pane className={s(styles, { pane: true })} basis="50%" main>
<Pane className={s(styles, { pane: true })}>
<Loader suspense>
<SqlResultTabs state={state} />
</Loader>
Expand Down
5 changes: 2 additions & 3 deletions webapp/packages/plugin-sql-editor/src/SqlEditor/SqlEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,9 @@ export const SqlEditor = observer<ISqlEditorProps>(function SqlEditor({ state, c

useEffect(() => {
if (isEditorEmpty) {
split.fixate('maximize', true);
split.state.setDisable(true);
} else if (split.state.disable) {
split.fixate('resize', false);
split.state.setSize(-1);
split.state.setDisable(false);
}
}, [isEditorEmpty]);

Expand Down
Loading