CB-4535. Remove Ability to edit all users team

server/bundles/io.cloudbeaver.service.admin/src/io/cloudbeaver/service/admin/impl/WebServiceAdmin.java

@@ -60,6 +60,7 @@
 public class WebServiceAdmin implements DBWServiceAdmin {
 
     private static final Log log = Log.getLog(WebServiceAdmin.class);
+    public static final String All_USERS_TEAM = "all_users";
 
     private final Map<String, WebPermissionDescriptor> permissionDescriptorByName = WebServiceRegistry.getInstance()
         .getWebServices()

server/bundles/io.cloudbeaver.service.security/src/io/cloudbeaver/service/security/CBEmbeddedSecurityController.java

@@ -19,6 +19,7 @@
 import com.google.gson.Gson;
 import com.google.gson.GsonBuilder;
 import com.google.gson.reflect.TypeToken;
+import io.cloudbeaver.DBWebException;
 import io.cloudbeaver.auth.*;
 import io.cloudbeaver.model.app.WebAppConfiguration;
 import io.cloudbeaver.model.app.WebAuthApplication;
@@ -212,19 +213,45 @@ public void deleteUser(String userId) throws DBCException {
         application.getEventController().addEvent(event);
     }
 
-    @Override
     public void setUserTeams(String userId, String[] teamIds, String grantorId) throws DBCException {
         try (Connection dbCon = database.openConnection()) {
             try (JDBCTransaction txn = new JDBCTransaction(dbCon)) {
-                setUserTeams(dbCon, userId, teamIds, grantorId);
-                txn.commit();
+                String defaultUserTeam = application.getAppConfiguration().getDefaultUserTeam();
+                if (!Arrays.asList(teamIds).contains(defaultUserTeam)) {
+                    String[] updatedTeamIds = Arrays.copyOf(teamIds, teamIds.length + 1);
+                    updatedTeamIds[teamIds.length] = defaultUserTeam;
+
+                    if (containsAllUsers(updatedTeamIds)) {
+                        setUserTeams(dbCon, userId, updatedTeamIds, grantorId);
+                        txn.commit();
+                    } else {
+                        throw new DBCException(application.getAppConfiguration().getDefaultUserTeam() + " role not editable");
+                    }
+                } else {
+                    if (containsAllUsers(teamIds)) {
+                        setUserTeams(dbCon, userId, teamIds, grantorId);
+                        txn.commit();
+                    } else {
+                        throw new DBCException(application.getAppConfiguration().getDefaultUserTeam() + " role not editable");
+                    }
+                }
             }
         } catch (SQLException e) {
             throw new DBCException("Error saving user teams in database", e);
         }
         addSubjectPermissionsUpdateEvent(userId, SMSubjectType.user);
     }
 
+    private boolean containsAllUsers(String[] array) {
+        for (String element : array) {
+            if (application.getAppConfiguration().getDefaultUserTeam().equals(element)) {
+                return true;
+            }
+        }
+        return false;
+    }
+
+
     public void setUserTeams(@NotNull Connection dbCon, String userId, String[] teamIds, String grantorId)
         throws SQLException {
         JDBCUtils.executeStatement(
@@ -1037,6 +1064,9 @@ public void deleteTeam(String teamId, boolean force) throws DBCException {
         if (CommonUtils.isNotEmpty(defaultUsersTeam) && defaultUsersTeam.equals(teamId)) {
             throw new DBCException("Default users team cannot be deleted");
         }
+        if (teamId.equals(defaultUsersTeam)) {
+            throw new DBCException("You can not delete all_users team");
+        }
         try (Connection dbCon = database.openConnection()) {
             if (!force) {
                 try (PreparedStatement dbStat = dbCon.prepareStatement(
@@ -2202,7 +2232,8 @@ private String findOrCreateExternalUserByCredentials(
             }
             Object reverseProxyUserTeams = sessionParameters.get(SMConstants.SESSION_PARAM_TRUSTED_USER_TEAMS);
             if (reverseProxyUserTeams instanceof List) {
-                setUserTeams(userId, ((List<?>) reverseProxyUserTeams).stream().map(Object::toString).toArray(String[]::new), userId);
+                List<String> reverseProxyUserTeamsList = (List<String>) reverseProxyUserTeams;
+                setUserTeams(userId, reverseProxyUserTeamsList.toArray(new String[0]), userId);
             }
         }
         return userId;