Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cb 4457 subcollections firestore #2338

Merged
merged 64 commits into from
Feb 13, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
be16e37
CB-4457. Add api for read subcollections firestore
Jan 26, 2024
66ca0d3
Merge branch 'devel' into CB-4457-subcollections-firestore
devnaumov Jan 26, 2024
dc72807
CB-4457. Move firestore to ee module
Jan 28, 2024
fa0f75c
CB-4457. Move firestore to ee module
Jan 28, 2024
f94eef4
CB-4457. Added annotations for firestore
Jan 29, 2024
171e04f
CB-4457. Added metaData
Jan 29, 2024
a514486
Merge branch 'CB-4457-subcollections-firestore' of https://github.com…
devnaumov Jan 29, 2024
da29798
Merge branch 'devel' into CB-4457-subcollections-firestore
devnaumov Jan 29, 2024
2fcea14
CB-4457. Fixed build
Jan 29, 2024
4c1ceea
Merge branch 'CB-4457-subcollections-firestore' of https://github.com…
devnaumov Jan 29, 2024
52936bb
Merge branch 'devel' into CB-4457-subcollections-firestore
devnaumov Jan 29, 2024
55acd52
CB-4457 add hasChildrenCollection flag
devnaumov Jan 29, 2024
8695dc4
CB-4457. Add new resultsRow
Jan 30, 2024
3282e1e
Merge remote-tracking branch 'origin/CB-4457-subcollections-firestore…
Jan 30, 2024
a034f16
Merge branch 'devel' into CB-4457-subcollections-firestore
DenisSinelnikov Jan 30, 2024
3ec850e
CB-4457. Renamed SQLResultRowMetaData parameters
Jan 30, 2024
b43ac2e
CB-4457 add rows with metadata to schema
devnaumov Jan 30, 2024
c1c3906
CB-4457. Fix gql
Jan 30, 2024
2332f98
CB-4457. Added logic to get Firestore subcollection
Jan 31, 2024
0186f6f
CB-4457. Refactor result, rename gql, added new type to return gql
Jan 31, 2024
a7f5f7f
Merge branch 'devel' into CB-4457-subcollections-firestore
DenisSinelnikov Jan 31, 2024
f69b31b
CB-4457. Revert list to map
Jan 31, 2024
169f4c9
CB-4457. Get Subcollections info
Feb 1, 2024
fcb9e01
CB-4457. Refactor code
Feb 1, 2024
8e0dc4e
Added sceleton for insert subcollection
Feb 2, 2024
7f34943
Merge branch 'devel' into CB-4457-subcollections-firestore
Feb 5, 2024
12d89f8
CB-4457. Added isSupportsDataFilter flag for subcollection
Feb 5, 2024
b590bfc
CB-4457 add locales
devnaumov Feb 5, 2024
0df9749
Merge branch 'devel' into CB-4457-subcollections-firestore
devnaumov Feb 5, 2024
72946a1
Merge remote-tracking branch 'origin/CB-4457-subcollections-firestore…
Feb 5, 2024
3954f87
Merge branch 'devel' into CB-4457-subcollections-firestore
Feb 5, 2024
8b4509d
Merge branch 'subcollections-firestore-insert' into CB-4457-subcollec…
Feb 5, 2024
dda99ed
CB-4457. Added isSupportsDataFilter flag for subcollection
Feb 5, 2024
132fe85
Merge branch 'CB-4457-subcollections-firestore' of https://github.com…
devnaumov Feb 5, 2024
f4f0132
Merge branch 'devel' into CB-4457-subcollections-firestore
devnaumov Feb 5, 2024
2452df1
CB-4457. Added update/insert logic for subcollection
Feb 5, 2024
43d5a7a
Merge branch 'CB-4457-subcollections-firestore' of https://github.com…
devnaumov Feb 5, 2024
77cc3ce
CB-4457 support collection editing
devnaumov Feb 6, 2024
ad3a9b5
Merge branch 'devel' into CB-4457-subcollections-firestore
DenisSinelnikov Feb 6, 2024
2e9dd39
CB-4457. Refactor after review, moved hierarchical model to ee.
Feb 7, 2024
bc72cbd
Merge remote-tracking branch 'origin/CB-4457-subcollections-firestore…
Feb 7, 2024
4a61dff
CB-4457 add SerializableKey
devnaumov Feb 7, 2024
b07fa86
Merge branch 'CB-4457-subcollections-firestore' of https://github.com…
devnaumov Feb 7, 2024
3e0ca83
CB-4457 keep only new rowsWithMetaData api
devnaumov Feb 7, 2024
88c6f85
CB-4457 review fixes
devnaumov Feb 7, 2024
fdb3694
Merge branch 'devel' into CB-4457-subcollections-firestore
devnaumov Feb 7, 2024
c11f17e
Merge remote-tracking branch 'origin/devel' into CB-4457-subcollectio…
Wroud Feb 8, 2024
a1fac7a
CB-4457 review fixes
Wroud Feb 8, 2024
3177f97
CB-4457. Refactor after review. Added logic for delete
Feb 8, 2024
51860c8
Merge branch 'CB-4457-subcollections-firestore' of https://github.com…
devnaumov Feb 8, 2024
38b591e
CB-4457 pass metadata in deleted rows
devnaumov Feb 8, 2024
2e75681
CB-4457 check row for undefined
devnaumov Feb 8, 2024
0adffe5
CB-4457 pass metadata when editing json
devnaumov Feb 8, 2024
c1605b9
CB-4457. Refactor edit, fix icons
Feb 8, 2024
549423d
CB-4457. Refactor makeDocumentInputValue, created new method for locator
Feb 8, 2024
b197aaa
Merge branch 'devel' into CB-4457-subcollections-firestore
dariamarutkina Feb 9, 2024
9af5005
CB-4457 try to get the current metadata for row
devnaumov Feb 12, 2024
44e940d
CB-4457 clear cache on result update
devnaumov Feb 12, 2024
78cbc6d
CB-4457 remove extra check
devnaumov Feb 12, 2024
6b603e7
Merge branch 'devel' into CB-4457-subcollections-firestore
dariamarutkina Feb 12, 2024
9e79b53
CB-4457. Fixed npe
Feb 12, 2024
20e60af
Merge remote-tracking branch 'origin/CB-4457-subcollections-firestore…
Feb 12, 2024
fa19009
Merge branch 'devel' into CB-4457-subcollections-firestore
dariamarutkina Feb 13, 2024
08f0e94
Merge branch 'devel' into CB-4457-subcollections-firestore
dariamarutkina Feb 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ mutation getSqlExecuteTaskResults($taskId: ID!) {
argumentCount
}
}
rows
rowsWithMetaData {
data
metaData
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ mutation updateResultsDataBatch(
updateRowCount
resultSet {
id
rows
rowsWithMetaData {
data
metaData
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,7 @@ import type { IResultSetValue } from './ResultSetFormatAction';
export class ResultSetDataAction extends DatabaseDataResultAction<IResultSetElementKey, IDatabaseResultSet> {
static dataFormat = [ResultDataFormat.Resultset];

get rows(): IResultSetValue[][] {
return this.result.data?.rows || [];
}

get rowsWithMetadata() {
get rows() {
return this.result.data?.rowsWithMetaData || [];
}

Expand All @@ -39,7 +35,6 @@ export class ResultSetDataAction extends DatabaseDataResultAction<IResultSetElem
super(source);
makeObservable(this, {
rows: computed,
rowsWithMetadata: computed,
columns: computed,
});
}
Expand Down Expand Up @@ -96,23 +91,23 @@ export class ResultSetDataAction extends DatabaseDataResultAction<IResultSetElem
return undefined;
}

return this.rows[row.index];
return this.rows[row.index].data;
}

getRowMetadata(row: IResultSetRowKey) {
if (row.index >= this.rowsWithMetadata.length) {
if (row.index >= this.rows.length) {
return undefined;
}

return this.rowsWithMetadata[row.index].metaData;
return this.rows[row.index].metaData;
}

getCellValue(cell: IResultSetElementKey): IResultSetValue | undefined {
if (cell.row === undefined || cell.column === undefined || cell.row.index >= this.rows.length || cell.column.index >= this.columns.length) {
return undefined;
}

return this.rows[cell.row.index][cell.column.index];
return this.rows[cell.row.index].data?.[cell.column.index];
}

getContent(cell: IResultSetElementKey): IResultSetContentValue | null {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export class ResultSetViewAction extends DatabaseDataAction<any, IDatabaseResult
return this.columns.map(c => ({ index: this.data.columns.indexOf(c) }));
}

get rows(): IResultSetValue[][] {
get rows() {
return this.data.rows;
}
Wroud marked this conversation as resolved.
Show resolved Hide resolved

Expand Down Expand Up @@ -137,7 +137,7 @@ export class ResultSetViewAction extends DatabaseDataAction<any, IDatabaseResult
throw new Error('Cell is out of range');
}

return this.rows[cell.row.index][cell.column.index];
return this.rows[cell.row.index].data?.[cell.column.index];
}

getContent(cell: IResultSetElementKey): IResultSetComplexValue | null {
Expand Down
Loading