CB-4504 transform coordinates according to the chosen srid #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wroud
approved these changes
Jan 26, 2024
| @@ -23,9 +23,11 @@ | |||
| "@cloudbeaver/core-sdk": "~0.1.0", | |||
| "@cloudbeaver/core-ui": "~0.1.0", | |||
| "@cloudbeaver/plugin-data-viewer": "~0.1.0", | |||
| "@types/proj4": "^2.5.5", | |||
There was a problem hiding this comment.
please move types to devDependencies
sergeyteleshev
approved these changes
Jan 26, 2024
| case 3857: | ||
| return 'EPSG3857'; | ||
| return 'EPSG:3857'; |
There was a problem hiding this comment.
I dont like this alien symbols. Lets move it to consts with meaning name
There was a problem hiding this comment.
it's code and you can google it, i don't agree that we need to move it to const (it will be looking like `const EPSG3857 = 'EPSG:3857'`)
There was a problem hiding this comment.
moreover number we get from server and it can by typed with gql enum but it seems no sense for it (again it's not a random number it's code)
| const activeElements = selection.getActiveElements(); | ||
| const firstActiveElement = activeElements[0]; | ||
| const firstActiveCell = firstActiveElement ? gis.getCellValue(firstActiveElement) : null; | ||
| const initialCrs: CrsKey = firstActiveCell?.srid ? getCrsKey(firstActiveCell.srid) : 'EPSG:3857'; |
There was a problem hiding this comment.
no magic numbers also
There was a problem hiding this comment.
this one can be moved to const DEFAULT_CRS = ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.