CB-4541 refactor: tree #2326
Merged
CB-4541 refactor: tree #2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return ( | ||
| <div ref={mountOptimization.setRootRef} style={{ overflow: 'auto', position: 'relative' }}> | ||
| <NodeSizeCacheContext.Provider value={elementsSizeCache}> |
There was a problem hiding this comment.
this amount of contexts scares me. at this point we should think how it would affect amount of rerenders in the tree
Comment on lines
+66
to
+71
| const [nodeCache] = useState( | ||
| () => | ||
| new MetadataMap<string, IComputedValue<INode>>(id => | ||
| computed(() => applyTransforms(id, options.getNode(id), [rootNodeTransformer(options.rootId), ...(options.nodeTransformers || [])])), | ||
| ), | ||
| ); |
There was a problem hiding this comment.
this is hard to undestand. please decompose it a little bit
Comment on lines
+72
to
+83
| const [childrenCache] = useState( | ||
| () => | ||
| new MetadataMap<string, IComputedValue<string[]>>(id => | ||
| computed(() => applyTransforms(id, options.getChildren(id), options.childrenTransformers)), | ||
| ), | ||
| ); | ||
| const [stateCache] = useState( | ||
| () => | ||
| new MetadataMap<string, IComputedValue<INodeState>>(id => | ||
| computed(() => applyTransforms(id, state.getState(id), [rootNodeStateTransformer(options.rootId), ...(options.stateTransformers || [])])), | ||
| ), | ||
| ); |
| }, | ||
| }), | ||
| { state: observable.ref, rootId: observable.ref }, | ||
| { state, rootId: options.rootId }, |
There was a problem hiding this comment.
this is not a pure function. please add here some deps so all functions uses this operator instead of get what it need outside of this scope
| return useObservableRef( | ||
| () => ({ | ||
| getState(id: string): Readonly<INodeState> { | ||
| return state.get(id); |
|
|
||
| this.element = element; | ||
| if (element) { | ||
| this.observer = new ResizeObserver(this.handleResize); |
There was a problem hiding this comment.
this one needs to be tested manually. cause as far as I remember resizeobserver can track only one axis. wether is width or height (dont remember which one). if it is important to track both I would recommend to use addEventListener('resize', this.handleResize)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.