CB-4539 fix: value panel auto type detection #2320
Conversation
| </Button> | ||
| </Container> | ||
| )} | ||
| <Container keepSize> |
There was a problem hiding this comment.
this button now shows all the time. it should only appear for truncated texts only
| @@ -125,16 +128,16 @@ export const TextValuePresentation: TabContainerPanelComponent<IDataValuePanelPr | |||
| const limit = bytesToSize(quotasService.getQuota('sqlBinaryPreviewMaxLength')); | |||
| const canSave = firstSelectedCell && contentAction.isDownloadable(firstSelectedCell); | |||
| const shouldShowPasteButton = isTextColumn && isTruncated; | |||
| const typeExtension = useMemo(() => getTypeExtension(state.currentContentType) ?? [], [state.currentContentType]); | |||
| const typeExtension = useMemo(() => getTypeExtension(contentType!) ?? [], [contentType]); | |||
There was a problem hiding this comment.
should we go with contentType ?? DEFAULT_CONTENT_TYPE? if something went wrong and contentType is null, then interface probably will be broken at all
There was a problem hiding this comment.
no we shouldn't because this is typescript check and we will never have contentType = null at this point (only if we will broke something)
| <Container keepSize center overflow> | ||
| <Container keepSize> |
There was a problem hiding this comment.
I suppose something went wrong inside container component if we have to do this twice Container thing in order to get a correct layout
There was a problem hiding this comment.
in this case it's because i don't want to add extra styles to TabsList
I suppose it's not always about problem in the Container but in matching other components together
| autoContentType = 'application/octet-stream;type=base64'; | ||
| autoLineWrapping = true; | ||
| break; | ||
| default: |
There was a problem hiding this comment.
'application/octet-stream;type=hex': - should we consider this case?
There was a problem hiding this comment.
we will detect tab automatically later, by now we just set base64 as default for all binary data
No description provided.