CB-3015: adds an fadeout animation & min close delay time to all noti… #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i also can suggest to not to show notification right when some process started |
Wroud
approved these changes
Jan 17, 2024
Wroud
requested changes
Jan 17, 2024
Comment on lines
27
to
32
| let closeDelay = 0; | ||
| let closeDelay = MIN_CLOSE_DELAY; | ||
|
|
||
| if (notification.type !== ENotificationType.Error && !notification.persistent && notification.autoClose !== false) { | ||
| closeDelay = FADE_TIMEOUT; |
There was a problem hiding this comment.
it's possible that we now broke this behavior (that some notifications must be closed instantly and some not)
and we have two different delays
now, all notifications will be closed after MIN_CLOSE_DELAY even when we want them to be open
check useActivationDelay in Snackbar
added 4 commits
January 17, 2024 16:52
…ng-from-a-database-for-more-time
…ng-from-a-database-for-more-time
added 2 commits
January 18, 2024 15:36
…00ms" This reverts commit 184aae7.
Wroud
approved these changes
Jan 18, 2024
…ng-from-a-database-for-more-time
Wroud
deleted the
CB-3015-show-notification-about-disconnecting-from-a-database-for-more-time
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.