CB-4264 password policy configuration #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagudin10
changed the title
Wroud
approved these changes
Jan 17, 2024
| minSpecialCharacters: 0, | ||
| }; | ||
|
|
||
| type ValidationResult = { isValid: true; errorMessage: null } | { isValid: false; errorMessage: string }; |
There was a problem hiding this comment.
why not to use:
interface IPasswordValidationSatus {
isValid: boolean;
message: string;
}
There was a problem hiding this comment.
Because there is no message if the status is valid
if(isValid) {message is null here}
sergeyteleshev
approved these changes
Jan 17, 2024
| }; | ||
| } | ||
|
|
||
| if (this.config.requiresUpperLowerCase && !(/[a-z]/.test(password) && /[A-Z]/.test(password))) { |
There was a problem hiding this comment.
lets create a file for a regexps. so it is reusable and in one place
const lowerCaseRegExp = /[a-z]/
const upperCaseRegExp = /[A-Z]/
There was a problem hiding this comment.
I think we can find a place for it after we will have a second use case
| }; | ||
| } | ||
|
|
||
| if ((password.match(/[!@#$%^&*(),.?":{}|<>]/g) || []).length < this.config.minSpecialCharacters) { |
| return { isValid: false, errorMessage: this.localizationService.translate('core_authentication_password_policy_upper_lower_case') }; | ||
| } | ||
|
|
||
| if ((password.match(/\d/g) || []).length < this.config.minDigits) { |
…cloudbeaver into CB-4264-password-policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.