CB-4039 logout with context #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wroud
requested changes
Jan 17, 2024
Comment on lines
+150
to
+152
| # Same as #authLogout, but returns additional information | ||
| @since(version: "23.3.3") | ||
| authLogoutExtended(provider: ID, configuration: ID): LogoutInfo! |
There was a problem hiding this comment.
it's not clear what Extended suffix means especially if we will remove authLogout
There was a problem hiding this comment.
Alexander decided authLogout function to be for a while for back backward compatibility. so this is why we have new function with Extended suffix
There was a problem hiding this comment.
problem is that Extended means nothing this is not good suffix for api
authLogoutInfo sound better
Wroud
requested changes
Jan 17, 2024
Comment on lines
110
to
124
| // TODO handle all redirect links once we know what to do with multiple popups issue | ||
| const { | ||
| authLogoutExtended: { redirectLinks }, | ||
| } = await this.userInfoResource.logout(providerId, configurationId); | ||
|
|
||
| if (redirectLinks.length) { | ||
| const oktaLink = redirectLinks[0]; | ||
| const id = `okta-logout-id-${uuid()}`; | ||
|
|
||
| this.windowsService.open(id, { | ||
| url: oktaLink, | ||
| width: 400, | ||
| height: 400, | ||
| }); | ||
| } |
There was a problem hiding this comment.
this logic must replace
if (userAuthConfiguration?.configuration.signOutLink) {
this.logoutConfiguration(userAuthConfiguration);
}we need to rewrite or remove it or change and maybe to change logoutConfiguration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.