CB-4401 feat: save value panel state per column #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyteleshev
approved these changes
Jan 4, 2024
| setCurrentTabId(firstTabId); | ||
| lastTabId.current = firstTabId; | ||
| } | ||
| if (displayed.length > 0 && (!currentTabId || !displayed.some(tab => tab.key === currentTabId))) { |
There was a problem hiding this comment.
const hasCurrentTabCells = currentTabId && displayed.some(tab => tab.key === currentTabId)
if (displayed.length > 0 && !hasCurrentTabCells)
| @@ -166,27 +161,40 @@ export const TextValuePresentation: TabContainerPanelComponent<IDataValuePanelPr | |||
| } | |||
| } | |||
|
|
|||
| let currentContentType = state.currentContentType; | |||
|
|
|||
| if (activeTabs.length > 0 && !activeTabs.some(tab => tab.key === currentContentType)) { | |||
There was a problem hiding this comment.
no need for first condition
There was a problem hiding this comment.
actually needed because some() acts like the "there exists" quantifier in mathematics. In particular, for an empty array, it returns false for any condition.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/some
devnaumov
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.