CB-4309 add keep alive interval for data source #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wroud
requested changes
Jan 11, 2024
Comment on lines
38
to
43
| const keepAliveRef = useCustomInputValidation<string>(value => { | ||
| if (Number(value) > MAX_KEEP_ALIVE_INTERVAL_IN_SECONDS) { | ||
| return translate('connections_connection_keep_alive_max_value_error', undefined, { keepAliveInterval: MAX_KEEP_ALIVE_INTERVAL_IN_SECONDS }); | ||
| } | ||
| return null; | ||
| }); |
There was a problem hiding this comment.
do we really need custom validation here? we set max value for input it should add browser default validation for this field
Wroud
approved these changes
Jan 12, 2024
serge-rider
deleted the
CB-4309-add-keep-alive-checkbox-for-connection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.