CB-3972 safe way to get action check for the document #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyteleshev
approved these changes
Dec 28, 2023
Wroud
requested changes
Jan 3, 2024
Comment on lines
91
to
97
| } | ||
| const selectionAction = model.source.getAction(resultIndex, ResultSetSelectAction); | ||
| const dataAction = model.source.getAction(resultIndex, ResultSetDataAction); | ||
| const selectionAction = model.source.tryGetAction(resultIndex, ResultSetSelectAction); | ||
| const dataAction = model.source.tryGetAction(resultIndex, ResultSetDataAction); | ||
|
|
||
| if (!selectionAction || !dataAction) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
it's will be better to:
- in DATA_CONTEXT_DV_DDM remove second generic from
IDatabaseDataModelso it will be set toIDatabaseDataResult
export const DATA_CONTEXT_DV_DDM = createDataContext<IDatabaseDataModel<IDatabaseDataOptions>>('data-viewer-database-data-model');
- in
DVResultSetGroupingPluginBootstrap.ts
don't register data presentation and menu creator ifmodel.source.getResult(resultIndex)?.dataFormat !== ResultDataFormat.Resultset
There was a problem hiding this comment.
or in case if we want to enable this presentation for other data formats it's better to use getActionImplementation(resultIndex, DatabaseSelectAction) and getActionImplementation(resultIndex, DatabaseDataAction) or check data format and get proper action for this format (or just cast type because getActionImplementation will return proper action but type will be common)
…dbeaver/cloudbeaver into CB-3974-grouping-panel-json-tab
Wroud
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.