CB-4388 add credentials menu #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyteleshev
approved these changes
Dec 28, 2023
| <Fragment key="user-credentials-list"> | ||
| {user.origins.map(origin => ( | ||
| {visibleCredentials.map(origin => ( | ||
| <UserCredentials key={origin.type + origin.subType} origin={origin} /> |
There was a problem hiding this comment.
string concatenation can sometimes lead to unexpected results. it is better to use concat method. In this case subtype can be undefined so it will lead to something like: "originundefined". And if those keys are duplicated react can rerender incorrect
I believe it is better to give a unique id here with some generateId helper
| const title = isLocal ? translate('authentication_administration_user_local') : origin.displayName; | ||
|
|
||
| return ( | ||
| <MenuItem key={origin.type + origin.subType} className={s(styles, { menuItem: true })} title={title}> |
There was a problem hiding this comment.
same here with unique id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.