CB-4317 fix: require authentication to load connection origin details #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const tab = useTab(tabId); | ||
| const translate = useTranslate(); | ||
| // const userInfoService = useService(UserInfoResource); | ||
| const userInfoService = useService(UserInfoResource); |
There was a problem hiding this comment.
why is it useService instead of useResource?
There was a problem hiding this comment.
fixed (actually here is both acceptable, but we can modify it to useResource to ensure that user is loaded and up to date in the component scope)
sergeyteleshev
approved these changes
Dec 4, 2023
devnaumov
approved these changes
Dec 5, 2023
serge-rider
pushed a commit
that referenced
this pull request
Dec 6, 2023
…#2189) * CB-4317 fix: require authentication to load connection origin details * CB-4317 fix: ensure user loaded and up to date --------- Co-authored-by: Daria Marutkina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.