CB-3704 feat(plugin-data-viewer): blob uploading #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itor-blob-uploading
…pload-big-files
…itor-blob-uploading
# Conflicts: # server/bundles/io.cloudbeaver.model/src/io/cloudbeaver/model/session/WebSession.java
…pload-big-files
Cb 4051 upload big files
server/bundles/io.cloudbeaver.model/src/io/cloudbeaver/model/session/WebSession.java
Outdated
Show resolved
Hide resolved
server/bundles/io.cloudbeaver.model/src/io/cloudbeaver/model/session/WebSession.java
Outdated
Show resolved
Hide resolved
...er/bundles/io.cloudbeaver.server/src/io/cloudbeaver/service/sql/WebSQLFileLoaderServlet.java
Outdated
Show resolved
Hide resolved
alexander-skoblikov
requested changes
Oct 4, 2023
...er/bundles/io.cloudbeaver.server/src/io/cloudbeaver/service/sql/WebSQLFileLoaderServlet.java
Outdated
Show resolved
Hide resolved
...er/bundles/io.cloudbeaver.server/src/io/cloudbeaver/service/sql/WebSQLFileLoaderServlet.java
Outdated
Show resolved
Hide resolved
server/bundles/io.cloudbeaver.server/src/io/cloudbeaver/service/sql/WebSQLProcessor.java
Outdated
Show resolved
Hide resolved
server/bundles/io.cloudbeaver.server/src/io/cloudbeaver/service/sql/WebSQLProcessor.java
Show resolved
Hide resolved
server/bundles/io.cloudbeaver.server/src/io/cloudbeaver/service/sql/impl/WebServiceSQL.java
Outdated
Show resolved
Hide resolved
alexander-skoblikov
requested changes
Oct 4, 2023
server/bundles/io.cloudbeaver.server/src/io/cloudbeaver/service/sql/WebSQLProcessor.java
Outdated
Show resolved
Hide resolved
devnaumov
requested changes
Oct 4, 2023
| @@ -92,6 +92,7 @@ export default [ | |||
| ['ui_close_all_to_the_left', 'Close all to the Left'], | |||
| ['ui_or', 'Or'], | |||
| ['ui_download', 'Download'], | |||
| ['ui_upload', 'Upload'], | |||
There was a problem hiding this comment.
We have ui_upload_file and ui_upload_files, do we need another one?
There was a problem hiding this comment.
they are different, but yep, it's a tricky case
| * you may not use this file except in compliance with the License. | ||
| */ | ||
|
|
||
| export function selectFiles(callback: (files: FileList | null) => any): void { |
There was a problem hiding this comment.
Probably we need to attach the input to the body and set its style to be hidden.
If it's not attached to the DOM, the click event might not work in some browsers.
...packages/plugin-data-viewer/src/DatabaseDataModel/Actions/ResultSet/ResultSetFormatAction.ts
Outdated
Show resolved
Hide resolved
| import type { IResultSetRowKey } from './IResultSetDataKey'; | ||
|
|
||
| export function compareResultSetRowKeys(a: IResultSetRowKey, b: IResultSetRowKey): number { | ||
| return a.index + a.subIndex / 10 - b.index - b.subIndex / 10; |
There was a problem hiding this comment.
Probably we need some comment here or create two named variables to it will be easier to read
Cb 3704 json fix
…hub.com/dbeaver/cloudbeaver into feat/cb-3704/data-editor-blob-uploading
…hub.com/dbeaver/cloudbeaver into feat/cb-3704/data-editor-blob-uploading
…hub.com/dbeaver/cloudbeaver into feat/cb-3704/data-editor-blob-uploading
serge-rider
requested changes
Oct 16, 2023
|
|
||
| Map<String, Object> variables = gson.fromJson(request.getParameter(REQUEST_PARAM_VARIABLES), MAP_STRING_OBJECT_TYPE); | ||
|
|
||
| String fileId = JSONUtils.getString(variables, FILE_ID); |
There was a problem hiding this comment.
We must validate it. File ID mustn't contain slashes or ..
serge-rider
approved these changes
Oct 16, 2023
alexander-skoblikov
approved these changes
Oct 16, 2023
devnaumov
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.