СB-4551 fix: icons has no data-test id

dbeaver · Jan 22, 2024 · a5f0fc5 · a5f0fc5
1 parent 87497cf
commit a5f0fc5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/webapp/packages/core-blocks/src/Icon.test.tsx b/webapp/packages/core-blocks/src/Icon.test.tsx
@@ -13,20 +13,20 @@ import { Icon } from './Icon';
 test('icons.svg#name', () => {
   (globalThis as any)._ROOT_URI_ = undefined;
 
-  render(<Icon name="test" />);
+  render(<Icon data-testid="Icon" name="test" />);
   expect(screen.getByTestId('Icon').querySelector('use')).toHaveAttribute('href', '/icons/icons.svg#test');
 });
 
 test('/image.jpg', () => {
   (globalThis as any)._ROOT_URI_ = undefined;
 
-  render(<Icon name="/image.jpg" />);
+  render(<Icon data-testid="Icon" name="/image.jpg" />);
   expect(screen.getByTestId('Icon').querySelector('use')).toHaveAttribute('href', '/image.jpg');
 });
 
 test('{_ROOT_URI_}/icons.svg#name', () => {
   (globalThis as any)._ROOT_URI_ = '/path/';
 
-  render(<Icon name="test" />);
+  render(<Icon data-testid="Icon" name="test" />);
   expect(screen.getByTestId('Icon').querySelector('use')).toHaveAttribute('href', '/path/icons/icons.svg#test');
 });
diff --git a/webapp/packages/core-blocks/src/Icon.tsx b/webapp/packages/core-blocks/src/Icon.tsx
@@ -14,7 +14,7 @@ export const Icon: React.FC<SVGAttributes<any>> = function Icon(props) {
   const cn = `icon ${className || ''}`;
   const url = GlobalConstants.absoluteUrl(name.startsWith('/') ? name : `/icons/icons.svg#${name}`);
   return (
-    <svg {...rest} data-testid="Icon" className={cn} aria-hidden="true" focusable="false">
+    <svg {...rest} className={cn} aria-hidden="true" focusable="false">
       <use href={url} />
     </svg>
   );