CB-4898 remove extra deps (#3100)

dbeaver · Nov 28, 2024 · 85bfcc0 · 85bfcc0
1 parent ea8605e
commit 85bfcc0
Show file tree

Hide file tree

Showing 5 changed files with 39 additions and 12 deletions.
diff --git a/webapp/packages/core-blocks/src/ErrorMessage.test.tsx b/webapp/packages/core-blocks/src/ErrorMessage.test.tsx
@@ -8,15 +8,12 @@
 import { expect, test } from '@jest/globals';
 import { screen, waitFor } from '@testing-library/react';
 
-import { coreEventsManifest } from '@cloudbeaver/core-events';
 import { coreLocalizationManifest } from '@cloudbeaver/core-localization';
-import { coreSettingsManifest } from '@cloudbeaver/core-settings';
-import { coreThemingManifest } from '@cloudbeaver/core-theming';
 import { createApp, renderInApp } from '@cloudbeaver/tests-runner';
 
 import { ErrorMessage } from './ErrorMessage.js';
 
-const app = createApp(coreEventsManifest, coreSettingsManifest, coreThemingManifest, coreLocalizationManifest);
+const app = createApp(coreLocalizationManifest);
 
 test('icons.svg#name', async () => {
   renderInApp(<ErrorMessage text="error" />, app);

diff --git a/webapp/packages/core-browser-settings/src/BrowserSettingsService.test.ts b/webapp/packages/core-browser-settings/src/BrowserSettingsService.test.ts
@@ -7,7 +7,6 @@
  */
 import { expect, test } from '@jest/globals';
 
-import { coreBrowserManifest } from '@cloudbeaver/core-browser';
 import { coreClientActivityManifest } from '@cloudbeaver/core-client-activity';
 import { coreLocalizationManifest } from '@cloudbeaver/core-localization';
 import { coreRootManifest, ServerConfigResource } from '@cloudbeaver/core-root';
@@ -30,7 +29,6 @@ import { coreBrowserSettingsManifest } from './manifest.js';
 const endpoint = createGQLEndpoint();
 const server = mockGraphQL(...mockAppInit(endpoint));
 const app = createApp(
-  coreBrowserManifest,
   coreBrowserSettingsManifest,
   coreRootManifest,
   coreSDKManifest,

diff --git a/webapp/packages/core-theming/src/ThemeSettingsService.test.ts b/webapp/packages/core-theming/src/ThemeSettingsService.test.ts
@@ -8,7 +8,6 @@
 import { expect, test } from '@jest/globals';
 
 import { coreClientActivityManifest } from '@cloudbeaver/core-client-activity';
-import { coreEventsManifest } from '@cloudbeaver/core-events';
 import { coreLocalizationManifest } from '@cloudbeaver/core-localization';
 import { coreRootManifest, ServerConfigResource } from '@cloudbeaver/core-root';
 import { createGQLEndpoint } from '@cloudbeaver/core-root/dist/__custom_mocks__/createGQLEndpoint.js';
@@ -31,7 +30,6 @@ const endpoint = createGQLEndpoint();
 const server = mockGraphQL(...mockAppInit(endpoint));
 const app = createApp(
   coreThemingManifest,
-  coreEventsManifest,
   coreRootManifest,
   coreSDKManifest,
   coreSettingsManifest,

diff --git a/webapp/packages/core-utils/src/isNumber.test.ts b/webapp/packages/core-utils/src/isNumber.test.ts
@@ -0,0 +1,38 @@
+/*
+ * CloudBeaver - Cloud Database Manager
+ * Copyright (C) 2020-2024 DBeaver Corp and others
+ *
+ * Licensed under the Apache License, Version 2.0.
+ * you may not use this file except in compliance with the License.
+ */
+import { describe, expect, test } from '@jest/globals';
+
+import { isNumber } from './isNumber.js';
+
+describe('isNumber', () => {
+  test('returns true for valid numbers', () => {
+    expect(isNumber(123)).toBe(true);
+    expect(isNumber(123.45)).toBe(true);
+    expect(isNumber('123')).toBe(true);
+    expect(isNumber('123.45')).toBe(true);
+    expect(isNumber(0)).toBe(true);
+  });
+
+  test('returns false for non-numeric strings', () => {
+    expect(isNumber('hello')).toBe(false);
+    expect(isNumber('123abc')).toBe(false);
+    expect(isNumber('')).toBe(false);
+  });
+
+  test('returns false for non-numeric values', () => {
+    expect(isNumber(NaN)).toBe(false);
+    expect(isNumber(Infinity)).toBe(false);
+    expect(isNumber(-Infinity)).toBe(false);
+    expect(isNumber(null)).toBe(false);
+    expect(isNumber(undefined)).toBe(false);
+    expect(isNumber({})).toBe(false);
+    expect(isNumber([])).toBe(false);
+    expect(isNumber(true)).toBe(false);
+    expect(isNumber(false)).toBe(false);
+  });
+});
diff --git a/...p/packages/plugin-navigation-tree/src/NodesManager/NavNodeView/NavNodeViewService.test.ts b/...p/packages/plugin-navigation-tree/src/NodesManager/NavNodeView/NavNodeViewService.test.ts
@@ -18,7 +18,6 @@ import { coreDialogsManifest } from '@cloudbeaver/core-dialogs';
 import { coreEventsManifest } from '@cloudbeaver/core-events';
 import { coreLocalizationManifest } from '@cloudbeaver/core-localization';
 import { coreNavigationTree } from '@cloudbeaver/core-navigation-tree';
-import { coreProductManifest } from '@cloudbeaver/core-product';
 import { coreProjectsManifest } from '@cloudbeaver/core-projects';
 import { coreRootManifest } from '@cloudbeaver/core-root';
 import { createGQLEndpoint } from '@cloudbeaver/core-root/dist/__custom_mocks__/createGQLEndpoint.js';
@@ -29,7 +28,6 @@ import { coreRoutingManifest } from '@cloudbeaver/core-routing';
 import { coreSDKManifest } from '@cloudbeaver/core-sdk';
 import { coreSettingsManifest } from '@cloudbeaver/core-settings';
 import { coreStorageManifest } from '@cloudbeaver/core-storage';
-import { coreThemingManifest } from '@cloudbeaver/core-theming';
 import { coreUIManifest } from '@cloudbeaver/core-ui';
 import { coreViewManifest } from '@cloudbeaver/core-view';
 import { datasourceContextSwitchPluginManifest } from '@cloudbeaver/plugin-datasource-context-switch';
@@ -45,7 +43,6 @@ const app = createApp(
   navigationTreePlugin,
   coreLocalizationManifest,
   coreEventsManifest,
-  coreProductManifest,
   coreRootManifest,
   coreSDKManifest,
   coreBrowserManifest,
@@ -63,7 +60,6 @@ const app = createApp(
   navigationTabsPlugin,
   coreNavigationTree,
   coreAppManifest,
-  coreThemingManifest,
   coreClientActivityManifest,
 );