Skip to content

Commit

Permalink
CB-3456 fix: eslint problems
Browse files Browse the repository at this point in the history
  • Loading branch information
Wroud committed Sep 22, 2023
1 parent b72aa1a commit 76a3def
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 4 deletions.
4 changes: 3 additions & 1 deletion webapp/packages/core-blocks/src/useFocus.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* you may not use this file except in compliance with the License.
*/
import { action, observable } from 'mobx';
import { useEffect, useLayoutEffect } from 'react';
import { useLayoutEffect } from 'react';

import { useObjectRef } from './useObjectRef';
import { useObservableRef } from './useObservableRef';
Expand Down Expand Up @@ -137,6 +137,8 @@ export function useFocus<T extends HTMLElement>({ autofocus, focusFirstChild, on
reference.removeEventListener('focusin', focusHandler);
reference.removeEventListener('focusout', blurHandler);
};
// TODO: probably we need to create a PR to https://github.com/facebook/react/blob/main/packages/eslint-plugin-react-hooks for custom stable hooks
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [reference]);

useLayoutEffect(
Expand Down
2 changes: 2 additions & 0 deletions webapp/packages/core-ui/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,11 @@ export * from './DragAndDrop/DNDProvider';
export * from './DragAndDrop/useDNDBox';
export * from './DragAndDrop/useDNDData';

export * from './Form/DATA_CONTEXT_FORM_STATE';
export * from './Form/FormBaseService';
export * from './Form/FormMode';
export * from './Form/FormState';
export * from './Form/formStateContext';
export * from './Form/formStatusContext';
export * from './Form/formValidationContext';
export * from './Form/IFormProps';
Expand Down
2 changes: 1 addition & 1 deletion webapp/packages/eslint-config/eslint-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"@typescript-eslint/ban-ts-comment": "off",
"@typescript-eslint/no-for-in-array": "off",
"@typescript-eslint/no-use-before-define": "off",
"@typescript-eslint/no-unused-vars": "warn",
"@typescript-eslint/no-unused-vars": ["warn", { "destructuredArrayIgnorePattern": "^_" }],
"@typescript-eslint/no-non-null-assertion": "off",
"@typescript-eslint/explicit-function-return-type": "off",
"@typescript-eslint/no-empty-function": "off",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* you may not use this file except in compliance with the License.
*/
import { UsersResource } from '@cloudbeaver/core-authentication';
import { DATA_CONTEXT_FORM_STATE } from '@cloudbeaver/core-ui/src/Form/DATA_CONTEXT_FORM_STATE';
import { DATA_CONTEXT_FORM_STATE } from '@cloudbeaver/core-ui';
import { createDataContext, DATA_CONTEXT_DI_PROVIDER } from '@cloudbeaver/core-view';

import type { AdministrationUserFormState } from '../AdministrationUserFormState';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* you may not use this file except in compliance with the License.
*/
import { UsersResource } from '@cloudbeaver/core-authentication';
import { DATA_CONTEXT_FORM_STATE } from '@cloudbeaver/core-ui/src/Form/DATA_CONTEXT_FORM_STATE';
import { DATA_CONTEXT_FORM_STATE } from '@cloudbeaver/core-ui';
import { createDataContext, DATA_CONTEXT_DI_PROVIDER } from '@cloudbeaver/core-view';

import type { AdministrationUserFormState } from '../AdministrationUserFormState';
Expand Down

0 comments on commit 76a3def

Please sign in to comment.