Skip to content

Commit

Permalink
CB-5274. Refactor after review
Browse files Browse the repository at this point in the history
  • Loading branch information
DenisSinelnikov committed Sep 9, 2024
1 parent 2e0ce76 commit 71340c9
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ default String getUserSignOutLink(
String getAcsLink(String id, @NotNull Map<String, Object> providerConfig) throws DBException;

@Nullable

Check warning on line 49 in server/bundles/io.cloudbeaver.model/src/io/cloudbeaver/auth/SMAuthProviderFederated.java

View check run for this annotation

Jenkins-CI-integration / CheckStyle Java Report

server/bundles/io.cloudbeaver.model/src/io/cloudbeaver/auth/SMAuthProviderFederated.java#L49

Missing a Javadoc comment.
String getDownloadMetadataFileLink(String id, @NotNull Map<String, Object> providerConfig) throws DBException;
String getEntityIdLink(String id, @NotNull Map<String, Object> providerConfig) throws DBException;

@Nullable
default String getRedirectLink(String id, @NotNull Map<String, Object> providerConfig) throws DBException {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public String getAcsLink() throws DBException {
public String getDownloadMetadataFileLink() throws DBException {
SMAuthProvider<?> instance = providerDescriptor.getInstance();
return instance instanceof SMAuthProviderFederated
? ((SMAuthProviderFederated) instance).getDownloadMetadataFileLink(getId(), config.getParameters())
? ((SMAuthProviderFederated) instance).getEntityIdLink(getId(), config.getParameters())
: null;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ type AdminAuthProviderConfiguration {
redirectLink: String
metadataLink: String
acsLink: String
downloadMetadataFileLink: String @since(version: "24.2.1")
entityIdLink: String @since(version: "24.2.1")
}

type WebFeatureSet {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ type AuthProviderConfiguration {
signOutLink: String
metadataLink: String
acsLink: String
downloadMetadataFileLink: String @since(version: "24.2.1")
entityIdLink: String @since(version: "24.2.1")
}

type AuthProviderCredentialsProfile {
Expand Down

0 comments on commit 71340c9

Please sign in to comment.