CB-4700 change if logic

dbeaver · Feb 21, 2024 · 680bf92 · 680bf92
1 parent c7cf17e
commit 680bf92
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/webapp/packages/plugin-data-viewer/src/DataViewerService.ts b/webapp/packages/plugin-data-viewer/src/DataViewerService.ts
@@ -27,13 +27,13 @@ export class DataViewerService {
   ) {}
 
   isDataEditable(connection: Connection) {
+    if (connection.readOnly) {
+      return false;
+    }
+
     const isAdmin = this.sessionPermissionsResource.has(EAdminPermission.admin);
     const disabled = this.dataViewerSettingsService.settings.getValue('disableEdit');
 
-    if (disabled) {
-      return isAdmin;
-    }
-
-    return !connection.readOnly;
+    return isAdmin || !disabled;
   }
 }