Merge branch 'devel' into CB-5583-prefetch-notification-icon

.github/workflows/backend-lint.yml

@@ -33,7 +33,7 @@ jobs:
 
       - uses: dbelyaev/action-checkstyle@master
         with:
-          github_token: ${{ secrets.github_token }}
+          github_token: ${{ secrets.GITHUB_TOKEN }}
           reporter: github-pr-review
           filter_mode: diff_context
           checkstyle_config: ./dbeaver-checkstyle-config.xml

README.md

@@ -22,70 +22,32 @@ You can see live demo of CloudBeaver here: https://demo.cloudbeaver.io
 
 ## Changelog
 
-### 24.1.5. 2024-08-19
-- Added right-click support to open the context menu in the Metadata Editor
-- The list of forbidden characters for naming and renaming files has been updated, now it includes the following characters: / : " \ ' <> | ? *
-- Many minor bug fixes, enhancements, and improvements have been made
-
-### 24.1.4. 2024-08-05
-- Redesigned administration navigation panel - now it is more compact and clear;
-- Added the ability to close editor tabs with the middle mouse button;
-- Improved display of the long error messages in the SQL Editor and Log viewer;
-- SQL Editor auto-completion was enhanced to get column, table, and function names faster.
-
-### 24.1.3. 2024-07-22
+### 24.2.0. 2024-09-02
+### Changes since 24.1.0:
+- General:
+  -    French language support was added (thanks to @matthieukhl)
+  -    Added the ability to close editor tabs with the middle mouse button
+  -    Added right-click support to open the context menu in the Metadata Editor
+  -    The list of forbidden characters for naming and renaming resource manager files has been updated, and now it includes the following characters: / : " \ ' <> | ? *
+  -    Application cookies security was improved
+- Authentication:
+  -    Improved LDAP authentication: added the ability to filter users via service account parameters and ability to specify custom unique user identifiers
 - Data Editor:
-  -    Enhanced IPv6 and DateTime32 data representation for Clickhouse;
-  -    Data editing was fixed for DuckDB;
+  -    Added additional notifications about the restricted operations
+  -    Enhanced IPv6 and DateTime32 data representation for Clickhouse
+  -    Data editing was fixed for DuckDB
 - SQL Editor:
-  -    We changed the save script icon to a floppy disk for better recognition;
-  -    The 'Use long objects names' preference behavior was enhanced for auto-completion actions;
-- DDL generation for Oracle Tablespaces was added (thanks to @pandya09);
-- Many minor bug fixes, enhancements, and improvements have been made.
-
-### 24.1.2. 2024-07-08
-- Added the ability to change the default commit mode for each connection separately;
-- Added additional notifications about restricted operations;
-- Improved application behavior when closing a connection - open editors won't be closed on disconnect;
-- Added the "Keep alive" setting for Db2 LUW and IMB i, Apache Kyuubi, Clickhouse, Firebird and Trino;
-- Fixed the dollar-quoted string parsing in the SQL editor for PostgreSQL;
-- Many minor bug fixes, enhancements, and improvements have been made.
-
-### 24.1.1. 2024-06-24
-- Unauthorized access vulnerability was fixed;
-- French language support was added (thanks to @matthieukhl);
-- Updated Firebird driver to version 5.0.4;
-- Many minor bug fixes, enhancements, and improvements have been made.
-
-### 24.1.0. 2024-06-03
-### Changes since 24.0.0:
-- General:
-  -    Added the ability to back up the internal database before schema migration (for H2 and PostgreSQL)
-  -    The process of application update has improved - you can track the application update process now;
-  -    Added the ability for users to configure personal settings for the interface, SQL editor, and data viewer through the settings panel
-  -    All popup dialogs became available for screen readers, including JAWS, to improve the experience for users with disabilities;
-- User authorization:
-  -    Security for unauthorized access enhanced;
-  -    Added LDAP authentication;
-- Data viewer and SQL editor:
-  -    Added support for manual and automatic modes for committing changes to the database
-  -    Large text values (more than 100 Kb) are now automatically opened in the Value panel;
-  -    Row count calculation in the grid can be canceled for Data Editor and SQL Editor;
-  -    Added the ability to set null values for BLOB and GIS data via the cell's context menu in the table;
-  -    Added spatial data visualization for DuckDB;
-  -    Aliases autocompletion fixed for DuckDB;
-  -    Procedure creation query recognition fixed for DB2i.
-- Connection settings:
-  -    Implemented support for utilizing environment variables within connection configurations;
-- Data transfer:
-  -    Added the ability to import data to the database from CSV file;
-  -    Added the ability to select a case for column names for export to CSV;
+  -    SQL Editor auto-completion was enhanced to get column, table, and function names faster
+  -    Fixed the dollar-quoted string parsing in the SQL Editor for PostgreSQL
+  -    Improved display of the long error messages in the SQL Editor and Log viewer
+  -    Changed the save script icon to a floppy disk for better recognition
+  -    Improved application behavior when closing a connection - open editors won't be closed on disconnect
+- Administration:
+  -    Redesigned administration navigation panel - now it is more compact and clear
+  -    Added the ability to change the default commit mode for each connection separately
+  -    Added the ability to configure the server property rootURI parameter (thanks to @arioko)
 - Databases:
-  -    Added a new Apache Kyuubi driver (thanks to @pan3793);
-  -    Enhanced security for connection through H2 driver;
-  -    DuckDB driver updated to version 0.10.2;
-  -    Oracle driver updated to version 23.2.0.0;
-  -    SQLite driver updated to version 3.44.1.0;
-  -    Clickhouse driver updated to version 0.6.0-patch2;
-  -    Trino driver updated to version 438 (thanks to @alaturqua).
+  -    Added the "Keep alive" setting for Db2 LUW and IMB i, Apache Kyuubi, Clickhouse, Firebird, and Trino
+  -    Updated Firebird driver to version 5.0.4
+  -    DDL generation for Oracle Tablespaces was added (thanks to @pandya09)
 

server/bundles/io.cloudbeaver.model/src/io/cloudbeaver/model/session/WebSessionEventsFilter.java

@@ -50,6 +50,9 @@ public void setSubscribedProjects(@NotNull Set<String> subscribedProjectIds) {
     }
 
     public boolean isEventAllowed(WSEvent event) {
+        if (event.isForceProcessed()) {
+            return true;
+        }
         if (!subscribedEventTopics.isEmpty() && !subscribedEventTopics.contains(event.getTopicId())
         ) {
             return false;

server/bundles/io.cloudbeaver.server/src/io/cloudbeaver/service/sql/WebSQLProcessor.java

@@ -795,6 +795,10 @@ public Object convertInputCellValue(DBCSession session, DBDAttributeBinding upda
                     cellRawValue,
                     false,
                     true);
+                //FIXME: fix array editing for nosql databases
+                if (realCellValue == null && cellRawValue != null && updateAttribute.getDataKind() == DBPDataKind.ARRAY) {
+                    throw new DBCException("Array update is not supported");
+                }
             } catch (DBCException e) {
                 //checks if this function is used only for script generation
                 if (justGenerateScript) {
@@ -1140,7 +1144,8 @@ private static DBCExecutionPurpose resolveQueryPurpose(DBDDataFilter filter) {
         return filter.hasFilters() ? DBCExecutionPurpose.USER_FILTERED : DBCExecutionPurpose.USER;
     }
 
-    private Object setCellRowValue(Object cellRow, WebSession webSession, DBCSession dbcSession, DBDAttributeBinding allAttributes, boolean withoutExecution) {
+    private Object setCellRowValue(Object cellRow, WebSession webSession, DBCSession dbcSession, DBDAttributeBinding allAttributes, boolean withoutExecution)
+        throws DBException {
         if (cellRow instanceof Map<?, ?>) {
             Map<String, Object> variables = (Map<String, Object>) cellRow;
             if (variables.get(FILE_ID) != null) {
@@ -1153,14 +1158,10 @@ private Object setCellRowValue(Object cellRow, WebSession webSession, DBCSession
                     var file = Files.newInputStream(path);
                     return convertInputCellValue(dbcSession, allAttributes, file, withoutExecution);
                 } catch (IOException | DBCException e) {
-                    return new DBException(e.getMessage());
+                    throw new DBException(e.getMessage());
                 }
             }
         }
-        try {
-            return convertInputCellValue(dbcSession, allAttributes, cellRow, withoutExecution);
-        } catch (DBCException e) {
-            return new DBException(e.getMessage());
-        }
+        return convertInputCellValue(dbcSession, allAttributes, cellRow, withoutExecution);
     }
 }

webapp/packages/core-cli/configs/jest.config.js

@@ -23,7 +23,7 @@ module.exports = {
   moduleNameMapper: {
     '\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$': require.resolve('./__mocks__/fileMock.js'),
     '\\.(css|scss|less)$': require.resolve('./__mocks__/styleMock.js'),
-    '^dexie$': require.resolve('dexie'),
+    // '^dexie$': require.resolve('dexie'),
   },
   // passWithNoTests: true,
   setupFiles: [require.resolve('fake-indexeddb/auto'), require.resolve('../tests/setup.js')],

webapp/packages/core-cli/configs/webpack.config.js

@@ -160,6 +160,11 @@ module.exports = (env, argv) => {
       removeAvailableModules: false,
       removeEmptyChunks: false,
       splitChunks: {
+        /*  this impacts how many chunks are created,
+            we need to keep less then 30 requests for js files for initial page load (with no editors)
+            we can reduce this number when we will split chunks properly
+        */
+        minSize: 128 * 1024,
         cacheGroups: {
           styles: {
             name: 'styles',

webapp/packages/core-cli/configs/webpack.product.config.js

@@ -38,8 +38,13 @@ module.exports = (env, argv) => {
 
       minimizer: [
         new EsbuildPlugin({
-            target: 'es2022',
+            include: /.*?\/(core|plugin|main|sso|packages)-.*/,
+            target: 'es2023',
             keepNames: true,
+        }),
+        new EsbuildPlugin({
+            exclude: /.*?\/(core|plugin|main|sso|packages)-.*/,
+            target: 'es2023',
             css: true,
         }),
     ],