Skip to content

Commit

Permalink
CB-4605 fix: sql editor shows datasets panels correctly (#2347)
Browse files Browse the repository at this point in the history
* CB-4605 fix: sql editor shows datasets panels correctly

* Revert "CB-4605 fix: sql editor shows datasets panels correctly"

This reverts commit 5e2afc5.

* CB-4605 fix: TE edit dataset works fine with new dividers

* CB-4605 revert sqleditor displayed editors state

* CB-4605 removed sqlEditor hack to open full size dataset

* Revert "CB-4605 removed sqlEditor hack to open full size dataset"

This reverts commit 7ad98e4.

* CB-4605 sqlEditor works as it was for EE and TE

---------

Co-authored-by: s.teleshev <[email protected]>
Co-authored-by: Evgenia Bezborodova <[email protected]>
  • Loading branch information
3 people authored Feb 5, 2024
1 parent 4d04f4b commit 590830c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
4 changes: 2 additions & 2 deletions webapp/packages/plugin-sql-editor/src/SqlEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@ export const SqlEditor = observer<Props>(function SqlEditor({ state }) {
<Loader suspense>
<CaptureView className={s(styles, { captureView: true })} view={sqlEditorView}>
<Split {...splitState} split="horizontal" sticky={30}>
<Pane className={s(styles, { pane: true })}>
<Pane className={s(styles, { pane: true })} basis="50%" main>
<SqlEditorLoader state={state} />
</Pane>
<ResizerControls />
<Pane className={s(styles, { pane: true })} basis="50%" main>
<Pane className={s(styles, { pane: true })}>
<Loader suspense>
<SqlResultTabs state={state} />
</Loader>
Expand Down
5 changes: 2 additions & 3 deletions webapp/packages/plugin-sql-editor/src/SqlEditor/SqlEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,9 @@ export const SqlEditor = observer<ISqlEditorProps>(function SqlEditor({ state, c

useEffect(() => {
if (isEditorEmpty) {
split.fixate('maximize', true);
split.state.setDisable(true);
} else if (split.state.disable) {
split.fixate('resize', false);
split.state.setSize(-1);
split.state.setDisable(false);
}
}, [isEditorEmpty]);

Expand Down

0 comments on commit 590830c

Please sign in to comment.