CB-4010 add to isArraysEqual edge cases + tests

webapp/packages/core-utils/src/isArraysEqual.test.ts

@@ -56,11 +56,21 @@ describe('Is array equals', () => {
     expect(isArraysEqual([{ a: 1 }], [{ a: 1 }], (a, b) => a.a === b.a, true)).toBe(true);
   });
 
-  test('should pass with array of objects (length > 1)', () => {
-    expect(isArraysEqual([{ b: 3 }, { a: 1 }], [{ a: 1 }, { b: 3 }])).toBe(true);
+  test('should not pass with no equal fn and array of objects (length > 1)', () => {
+    expect(isArraysEqual([{ b: 3 }, { a: 1 }], [{ a: 1 }, { b: 3 }])).toBe(false);
   });
 
-  test('should pass with primitive and non primitive in array', () => {
-    expect(isArraysEqual([1, 1, { a: 1 }, 2], [2, { a: 1 }, 1, 1])).toBe(true);
+  test('should not pass with no equal fn and primitive and non primitive in array', () => {
+    expect(isArraysEqual([1, 1, { a: 1 }, 2], [2, { a: 1 }, 1, 1])).toBe(false);
+  });
+
+  test('should pass with equal fn and array of objects (length > 1)', () => {
+    const isEqual = jest.fn((a: { a: number }, b: { a: number }) => a.a === b.a);
+    expect(isArraysEqual([{ a: 3 }, { a: 1 }], [{ a: 1 }, { a: 3 }], isEqual)).toBe(true);
+  });
+
+  test('should pass with equal fn and primitive and non primitive in array', () => {
+    const isEqual = jest.fn((a: { a: number }, b: { a: number }) => a.a === b.a);
+    expect(isArraysEqual([1, { a: 3 }, { a: 1 }] as any, [1, { a: 1 }, { a: 3 }] as any, isEqual)).toBe(true);
   });
 });

webapp/packages/core-utils/src/isArraysEqual.ts

@@ -41,13 +41,17 @@ export function isArraysEqual<T>(first: T[], second: T[], isEqual: (a: T, b: T)
           map.set(currentSecond, Number(map.get(currentSecond)) - 1);
           break;
         }
+
+        if (j === first.length - 1) {
+          return false;
+        }
       }
       continue;
     }
 
     const mapValue = map.get(currentSecond);
 
-    if (mapValue === undefined || mapValue === 0) {
+    if (mapValue === undefined || mapValue <= 0) {
       return false;
     }