Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Refactoring #194

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Small Refactoring #194

wants to merge 1 commit into from

Conversation

fampion
Copy link

@fampion fampion commented Jul 7, 2023

Hi, I used InteliJDeodorant to identify Code Smells and I refactored some of them. Mostly made some complex methods simpler by creating getters.

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 86.44% and project coverage change: +0.38 🎉

Comparison is base (acf2840) 79.39% compared to head (0399107) 79.77%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #194      +/-   ##
============================================
+ Coverage     79.39%   79.77%   +0.38%     
- Complexity      817      826       +9     
============================================
  Files            71       71              
  Lines          2140     2151      +11     
  Branches        268      261       -7     
============================================
+ Hits           1699     1716      +17     
+ Misses          356      351       -5     
+ Partials         85       84       -1     
Impacted Files Coverage Δ
.../java/com/github/davidmoten/rtree/Serializers.java 58.20% <50.00%> (+1.45%) ⬆️
...ithub/davidmoten/rtree/fbs/NonLeafFlatBuffers.java 81.35% <50.00%> (+0.65%) ⬆️
...ithub/davidmoten/rtree/internal/RectangleUtil.java 62.00% <50.00%> (+4.00%) ⬆️
...java/com/github/davidmoten/rtree/Backpressure.java 100.00% <100.00%> (ø)
...c/main/java/com/github/davidmoten/rtree/RTree.java 97.93% <100.00%> (+0.04%) ⬆️
...ava/com/github/davidmoten/rtree/SplitterRStar.java 96.29% <100.00%> (+0.29%) ⬆️
...ub/davidmoten/rtree/fbs/SerializerFlatBuffers.java 100.00% <100.00%> (ø)
...ithub/davidmoten/rtree/internal/NonLeafHelper.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant