Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements #25

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Improvements #25

wants to merge 18 commits into from

Conversation

lucaslm
Copy link

@lucaslm lucaslm commented Apr 26, 2021 •
edited
Loading

Here are some changes which I consider improvements.

  • Removal of embebbed plugin code of jQuery-Sortable-lists. From now on it should be included like any other requirement.
  • Deletion confirmation can now be either a native dialog or a bootstrap modal (see setting useModalConfirmation)
  • Refactoring export methods. Instead of just getString, now there are getJson, getJsonString, getArray and getArrayString, as well as the ones from jQuery-Sortable-lists.
  • Responsiveness on horizontal padding of items.

I have some other ideas for improvements, but for now this is enough for evaluating and discussing.

Lucas Madureira added 18 commits April 22, 2021 12:28
Removing sortablelists plugin from code and including it on requireme…
3e9a9f5 
…nts list.

Necessary adjustments are:

* Tweaks on generated DOM now accomplished by a mutation observer
* Sortablelists export methods are now exposed by this plugin (requires data to
have an id property)
Adding DOM tweak to user created elements as well
ba248c8
Fixing event being bound twice whether there were two editor on same …
aa3e06f 
…page
Refactoring export methods
e380c4c
Adding deletion confirmation modal option
968648a
Using old syntax to support older browsers
1a7d592
Merge branch 'master' into improvements
8502c75
Simplifying modal structure and creation
52dac31
Ensuring ids uniqueness in other parts of the code
0145d67
update readme
23d71ca
Improving horizontal padding of items.
63c44e6
Updating DOM on onChange event instead of complete event, which is al…
fd19110 
…so trigged even if item position didin't change.
Preventing modal from being created more than once when component's D…
0cd7aeb 
…OM is rebuild
Moving modal creation to plugin constructor and out of setData, since…
ef3fc51 
… it does not depend on it
iconPicker use conditioned to plugin being present on initialization
eb8f7c9
Making adding item on any position possible
34a8966
Adding option to show or hide icons
32a2b74
typo fix
5a4dca0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lucaslm