Add Histogram exemplar support #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybasket
approved these changes
Jan 31, 2024
alexcardell
force-pushed
the
exemplars
branch
from
4d8abf3 to
e66edfd
Compare
|
The Java conversion error failing the 2.12 build goes away now that this branch is updated, as the Labels Map API has been removed |
|
Thank you for your contribution, released as https://github.com/davenverse/epimetheus/releases/tag/v0.6.0-M2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Prometheus exemplars
Allowing jumping from histogram buckets to relevant trace IDs
I feel an extension method in a Natchez / Otel4s module could be helpful for auto exemplar-ing traceable effects, but that could quite easily be done in user-land
Whether the tuple overload method is necessary is up for debate, but it does match the Java API with a small improvement: no assumption that the varargs list is even