Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: use pulsar server in docker #120

Merged
merged 11 commits into from
Apr 9, 2024
Merged

Tests: use pulsar server in docker #120

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
bcb6fc6
make build compatible with jdk21
nicoloboschi Apr 8, 2024
a703872
tests: use pulsar server in docker
nicoloboschi Apr 9, 2024
e095378
spotbugs
nicoloboschi Apr 9, 2024
f8b8e60
fix
nicoloboschi Apr 9, 2024
00eb4e2
fix
nicoloboschi Apr 9, 2024
2475802
fix test
nicoloboschi Apr 9, 2024
d7ba980
fix test
nicoloboschi Apr 9, 2024
550ad16
add ssh
nicoloboschi Apr 9, 2024
d790331
timeout
nicoloboschi Apr 9, 2024
ca695f1
Fix test and also wait for Pulsar to be ready
eolivelli Apr 9, 2024
3345d0c
fix log
nicoloboschi Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pulsar-jms/src/test/java/com/datastax/oss/pulsar/jms/VirtualDestinationsConsumerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,8 @@ public void testPatternConsumerAddingTopicWithServerSideFilters() throws Excepti
pulsarContainer
.getAdmin()
.topics()
.createSubscription(
topicName, "jms-queue", MessageId.earliest, false, subscriptionProperties);
.updateSubscriptionProperties(
nicoloboschi marked this conversation as resolved.
Show resolved Hide resolved
topicName, "jms-queue", subscriptionProperties);

Queue newDestination = session.createQueue(topicName);
TextMessage nextMessage = session.createTextMessage("new");
Expand Down
11 changes: 6 additions & 5 deletions pulsar-jms/src/test/java/com/datastax/oss/pulsar/jms/utils/PulsarContainerExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@

@Slf4j
public class PulsarContainerExtension implements BeforeAllCallback, AfterAllCallback {
public static final String PULSAR_IMAGE = "apachepulsar/pulsar:3.0.0";
private PulsarContainer pulsarContainer;
private Consumer<PulsarContainerExtension> onContainerReady;
private Map<String, String> env = new HashMap<>();
Expand Down Expand Up @@ -67,7 +68,7 @@ public void afterAll(ExtensionContext extensionContext) {
public void beforeAll(ExtensionContext extensionContext) {
network = Network.newNetwork();
pulsarContainer =
new PulsarContainer(DockerImageName.parse("apachepulsar/pulsar:3.0.0"))
new PulsarContainer(DockerImageName.parse(PULSAR_IMAGE))
.withNetwork(network)
.withEnv(env)
.withLogConsumer(
Expand All @@ -76,13 +77,13 @@ public void beforeAll(ExtensionContext extensionContext) {
MountableFile.forHostPath("target/classes/filters"), "/pulsar/filters");
// start Pulsar and wait for it to be ready to accept requests
pulsarContainer.start();
admin =
PulsarAdmin.builder()
.serviceHttpUrl("http://localhost:" + pulsarContainer.getMappedPort(8080))
.build();
if (onContainerReady != null) {
onContainerReady.accept(this);
}
admin =
PulsarAdmin.builder()
.serviceHttpUrl("http://localhost:" + pulsarContainer.getMappedPort(8080))
.build();
}

public PulsarContainerExtension withOnContainerReady(
Expand Down
Loading