fixes

datastax · Apr 9, 2024 · 8c534ad · 8c534ad
1 parent 9c620f5
commit 8c534ad
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 14 deletions.
diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
@@ -30,9 +30,6 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-maven-
 
-      - name: Setup upterm session
-        uses: lhotari/action-upterm@v1
-
       - name: Build and test
         run: mvn -B clean javadoc:javadoc verify
 
diff --git a/...r-jms-admin-api/src/main/java/com/datastax/oss/pulsar/jms/api/JMSDestinationMetadata.java b/...r-jms-admin-api/src/main/java/com/datastax/oss/pulsar/jms/api/JMSDestinationMetadata.java
@@ -15,7 +15,6 @@
  */
 package com.datastax.oss.pulsar.jms.api;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.List;
 import java.util.Map;
 import lombok.Data;
@@ -41,7 +40,6 @@ protected JMSDestinationMetadata(String destination) {
 
   /** The destination maps to a physical topic, partitioned or non-partitioned. */
   @ToString
-  @SuppressFBWarnings({"EI_EXPOSE_REP2", "EI_EXPOSE_REP"})
   public abstract static class PhysicalPulsarTopicMetadata extends JMSDestinationMetadata {
     public PhysicalPulsarTopicMetadata(
         String destination,
@@ -89,7 +87,6 @@ public boolean isVirtualDestination() {
 
   /** The destination is a JMS Topic, that maps to a Pulsar Topic with a set of Subscriptions. */
   @ToString
-  @SuppressFBWarnings({"EI_EXPOSE_REP2", "EI_EXPOSE_REP"})
   public static final class TopicMetadata extends PhysicalPulsarTopicMetadata {
 
     public TopicMetadata(
@@ -122,7 +119,6 @@ public boolean isTopic() {
 
   /** The destination is a JMS Queue. A Queue is mapped to a single Pulsar Subscription. */
   @ToString
-  @SuppressFBWarnings({"EI_EXPOSE_REP2", "EI_EXPOSE_REP"})
   public static final class QueueMetadata extends PhysicalPulsarTopicMetadata {
     public QueueMetadata(
         String destination,
@@ -170,7 +166,6 @@ public boolean isTopic() {
 
   /** The Destination is a Virtual Destination, with the set of actual physical destinations. */
   @ToString
-  @SuppressFBWarnings({"EI_EXPOSE_REP2", "EI_EXPOSE_REP"})
   public static final class VirtualDestinationMetadata extends JMSDestinationMetadata {
     private final boolean multiTopic;
     private final boolean regex;
@@ -198,7 +193,6 @@ public boolean isMultiTopic() {
       return multiTopic;
     }
 
-    @SuppressFBWarnings({"EI_EXPOSE_REP2", "EI_EXPOSE_REP"})
     public List<JMSDestinationMetadata> getDestinations() {
       return destinations;
     }
@@ -226,7 +220,6 @@ public final String getDestination() {
   /** Metadata about a Pulsar Subscription. */
   @Data
   @ToString
-  @SuppressFBWarnings({"EI_EXPOSE_REP2", "EI_EXPOSE_REP"})
   public static final class SubscriptionMetadata {
     private final String subscriptionName;
 
@@ -243,7 +236,6 @@ public SubscriptionMetadata(String subscriptionName) {
   /** Metadata about a Pulsar Consumer. */
   @Data
   @ToString
-  @SuppressFBWarnings({"EI_EXPOSE_REP2", "EI_EXPOSE_REP"})
   public static final class ConsumerMetadata {
     @Getter private final String consumerName;
 
@@ -265,7 +257,6 @@ public ConsumerMetadata(String consumerName) {
   /** Metadata about a Pulsar Producer. */
   @Data
   @ToString
-  @SuppressFBWarnings({"EI_EXPOSE_REP2", "EI_EXPOSE_REP"})
   public static final class ProducerMetadata {
     @Getter private final String producerName;
 

diff --git a/pulsar-jms/src/main/java/com/datastax/oss/pulsar/jms/CompositeEnumeration.java b/pulsar-jms/src/main/java/com/datastax/oss/pulsar/jms/CompositeEnumeration.java
@@ -15,12 +15,10 @@
  */
 package com.datastax.oss.pulsar.jms;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.Enumeration;
 import java.util.List;
 import java.util.NoSuchElementException;
 
-@SuppressFBWarnings({"EI_EXPOSE_REP2", "EI_EXPOSE_REP"})
 public final class CompositeEnumeration implements Enumeration {
   private final List<? extends Enumeration> enumerations;
   private int currentEnumeration = 0;