Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Use CORs on all listen and serve code paths #119

Merged
merged 1 commit into from
May 5, 2020
Merged

Fix: Use CORs on all listen and serve code paths #119

merged 1 commit into from
May 5, 2020

Conversation

mpenick
Copy link
Contributor

@mpenick mpenick commented May 4, 2020 •
edited
Loading

Relates to: #118

@mpenick mpenick requested a review from jorgebay May 4, 2020 19:25
@mpenick mpenick mentioned this pull request May 4, 2020
Open
jorgebay
jorgebay approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@jorgebay jorgebay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to unify it.

I've also filed #122 to make sure the playground points to the right protocol and host name.

@mpenick mpenick merged commit 05174de into master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgebay jorgebay jorgebay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpenick @jorgebay