Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set publish as display #44

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: set publish as display #44

wants to merge 3 commits into from

Commits on Apr 12, 2024

  1. fix: set publish as display 

    Tried to go back in the history to see when this field disappeared but
could not see anything. Do you think it could be related to the switch
from prometheus, @Herkarl? Anyway, no it is being set explicitly on a
post to `admin/edit`.

Resolves #40
    @niklasvatn @foodelevator
    niklasvatn authored and foodelevator committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    fb7e6f4 View commit details
    Browse the repository at this point in the history

  2. fix: don't write over publish_as 

    This is a problem in the live version as well. This is a weird fix, but
best I could do now. I think we should disable the `publish_as` selector
when someone but the user updates  the post.
    @niklasvatn @foodelevator
    niklasvatn authored and foodelevator committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    1b9639b View commit details
    Browse the repository at this point in the history

  3. fix: only allow editing publish_as if you have the current mandate 

    I think it would make sense to be able to change publish_as in other cases too, but
that would require fetching their names from dfunkt separately, so this seems like a
least-effort good-enough solution

With the behaviour before this commit, you could not change the mandate of an existing
post, even if you just created it (which to me seems unneccessarily restrictive). But
it seemed like you could in the frontend.
    @foodelevator
    foodelevator committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    98a4c52 View commit details
    Browse the repository at this point in the history