Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for loading in link trees depending on subdomain #7

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Benjaneb
Copy link
Contributor

Aaallt is now a link tree generator.

Copy link
Member

@foodelevator foodelevator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Got some nitpicks though

links/sm.json Outdated Show resolved Hide resolved
links/systems.json Outdated Show resolved Hide resolved
links/sm.json Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
links/sm.json Outdated Show resolved Hide resolved
links/sm.json Outdated Show resolved Hide resolved
links/sm.json Outdated Show resolved Hide resolved
links/sm.json Outdated Show resolved Hide resolved
links/sm.json Outdated Show resolved Hide resolved
@Benjaneb
Copy link
Contributor Author

Next step is making the other text on the page customizable so you don't have to review until then.

@foodelevator
Copy link
Member

I believe the current status of this is that Dr. Ek finally found some common since and decided that this system is not needed.

@Benjaneb
Copy link
Contributor Author

No way, how could Olof betray me like this 😭

@Benjaneb Benjaneb marked this pull request as ready for review November 21, 2024 21:28
@Herkarl
Copy link
Member

Herkarl commented Nov 22, 2024

Had a thought: wouldn't it be cleaner to have an env-var determine the content rather than the subdomain? Or was the plan to only have a single instance of the service running with multiple DNS-records pointing to it?

description: Se dagordningen och bilagorna för mötet
url: https://dsekt.se/handlingar
icon: https://dsekt-assets.s3.amazonaws.com/namnder/systemgruppen/sm/handlingar.png
color: "#ab000d"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg

Copy link
Member

@foodelevator foodelevator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i still think this should be at most a separate html site, but a pdf would also work :)

go.mod Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@Benjaneb
Copy link
Contributor Author

i still think this should be at most a separate html site, but a pdf would also work :)

So, load different html files that already have the title and the other html in it, instead of in the yaml file?

@foodelevator
Copy link
Member

foodelevator commented Nov 23, 2024

no

@Benjaneb
Copy link
Contributor Author

Explain, or merge

@foodelevator
Copy link
Member

want links relevant for an sm? make a pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants