Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFAL/License page - wrong layout in Firefox #721

Merged
merged 3 commits into from
Oct 30, 2024
Merged

UFAL/License page - wrong layout in Firefox #721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5da75a3
Removed flex class and used width style instead of col
milanmajchrak Oct 11, 2024
af3b1bb
Removed unsued class
milanmajchrak Oct 11, 2024
a11b075
Changed style in the html into classes
milanmajchrak Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 19 additions & 18 deletions src/app/clarin-licenses/clarin-license-table/clarin-license-table.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,32 +22,33 @@
[retainScrollPosition]="true">
<table class="table table-striped table-bordered align-middle my-2">
<thead>
<tr class="col-12">
<th class="col-1" style="width: 3.5%; flex: 0 0 3.5%;max-width: 3.5%;"></th>
<th class="col-3">{{"clarin-license.table.name" | translate}}</th>
<th class="col-2">{{"clarin-license.table.definition" | translate}}</th>
<tr>
<th class="wm-3p5"></th>
<th class="w-25">{{"clarin-license.table.name" | translate}}</th>
<th class="w-20">{{"clarin-license.table.definition" | translate}}</th>
<th>{{"clarin-license.table.confirmation" | translate}}</th>
<th>{{"clarin-license.table.required-user-info" | translate}}</th>
<th class="w-12">{{"clarin-license.table.required-user-info" | translate}}</th>
<th>{{"clarin-license.table.label" | translate}}</th>
<th >{{"clarin-license.table.extended-labels" | translate}}</th>
<th >{{"clarin-license.table.bitstreams" | translate}}</th>
<th>{{"clarin-license.table.extended-labels" | translate}}</th>
<th>{{"clarin-license.table.bitstreams" | translate}}</th>
</tr>
</thead>
<tbody>
<tr *ngFor="let cLicense of cLicenses?.page" [id]="'clarin-license-row-' + cLicense.id" class="col-12">
<td class="col-1" style="width: 3.5%; flex: 0 0 3.5%;max-width: 3.5%;">
<tr *ngFor="let cLicense of cLicenses?.page" [id]="'clarin-license-row-' + cLicense.id">
<td class="wm-3p5">
<input class="collection-checkbox"
[ngModel]="selectedLicense?.id === cLicense.id"
(change)="switchSelectedLicense(cLicense)"
type="checkbox"
name="{{cLicense.id}}"></td>
<td class="col-3">{{cLicense?.name}}</td>
<td class="col-2">{{cLicense?.definition}}</td>
[ngModel]="selectedLicense?.id === cLicense.id"
(change)="switchSelectedLicense(cLicense)"
type="checkbox"
name="{{cLicense.id}}">
</td>
<td class="w-25">{{cLicense?.name}}</td>
<td class="w-20">{{cLicense?.definition}}</td>
<td>{{cLicense?.confirmation}}</td>
<td>{{cLicense?.requiredInfo | dsCLicenseRequiredInfo}}</td>
<td class="w-12">{{cLicense?.requiredInfo | dsCLicenseRequiredInfo}}</td>
<td>{{cLicense?.clarinLicenseLabel?.label}}</td>
<td >{{cLicense?.extendedClarinLicenseLabels | dsExtendedCLicense}}</td>
<td >{{cLicense?.bitstreams}}</td>
<td>{{cLicense?.extendedClarinLicenseLabels | dsExtendedCLicense}}</td>
<td>{{cLicense?.bitstreams}}</td>
</tr>
</tbody>
</table>
Expand Down
13 changes: 13 additions & 0 deletions src/app/clarin-licenses/clarin-license-table/clarin-license-table.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,16 @@
table-layout: fixed;
word-wrap: break-word;
}

.w-20 {
width: 20%;
}

.w-12 {
width: 12%;
}

.wm-3p5 {
width: 3.5%;
max-width: 3.5%;
}
Loading