Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RDKit SMILES parsing #23

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Fix RDKit SMILES parsing #23

merged 1 commit into from
Jan 2, 2024

Conversation

maclandrol
Copy link
Member

Changelogs


Checklist:

  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation if a new function is added, or an existing one is deleted. Eventually consider making a new tutorial for new features.
  • Write concise and explanatory changelogs below.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

The original discussion related to this PR can be found here: #22.

@maclandrol maclandrol added the fix Fix a bug label Jan 2, 2024
@maclandrol
Copy link
Member Author

Ping @hjuinj for review.

Copy link

@hjuinj hjuinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Emmanuel. LGTM
May I ask will the pip package be automatically updated upon merging?

@maclandrol
Copy link
Member Author

Thank you, Emmanuel. LGTM May I ask will the pip package be automatically updated upon merging?

Yes, there will be a new release after merging. I will ping you back here when it's available.

@maclandrol maclandrol merged commit d02a0e7 into main Jan 2, 2024
3 checks passed
@maclandrol
Copy link
Member Author

PyPi version released. conda-forge will be later in the week.

@hjuinj
Copy link

hjuinj commented Jan 2, 2024

Thanks Emmanuel for the super swift resolution, and kudos on the great work on SAFE.

@maclandrol maclandrol deleted the fix/rdkit-smiles-parser branch January 5, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants