Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #plugin action not working in modern versions of Sketch #286

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #plugin action not working in modern versions of Sketch #286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion sketch/src/sketch/actions/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,11 @@ export function perform(condition, layer, params) {
setCommandParamsToMetadata(layer, params)

// run the command
NSApp.delegate().runPluginCommand(command)
if (NSApp.delegate().runPluginCommand_fromMenu_context_) {
NSApp.delegate().runPluginCommand_fromMenu_context_(command, null, {})
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory we might use the context argument here to pass the same command params as we do via userInfo, but it will suffer from the same serialization limitations, so I wouldn't bother.

} else {
throw new Error("The current version of Sketch is not supported.")
}

// remove params
removeCommandParamsFromMetadata(layer)
Expand Down