Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update S3 example URLs to new formats #1236

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

mikapfl
Copy link
Contributor

@mikapfl mikapfl commented Sep 10, 2024

Amazon has streamlined their s3 endpoint naming:

  • it is not s3-region in some regions and s3.region in others anymore, it is s3.region everywhere
  • if you want IPv6 support (it's about time), you need to use s3.dualstack.region instead.

Updating the example in the chapter on using S3, hopefully most people setting this up will not need to look this info up anymore.

Copy link

welcome bot commented Sep 10, 2024

Thank You Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. https://doi.org/10.5281/zenodo.3332808) Wohoo! 🎉 Thanks for opening your first pull request to the DataLad Handbook! 😎 We really appreciate your time and effort to contribute to the project - you're amazing! 👏

Copy link
Contributor

@adswa adswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@adswa adswa merged commit 1cb3ad1 into datalad-handbook:main Sep 10, 2024
3 checks passed
Copy link

welcome bot commented Sep 10, 2024

Congratulations Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. https://doi.org/10.5281/zenodo.3332808) Congrats on merging your first pull request! 🎉 The DataLad Handbook team appreciates your contribution greatly, and we want to say thanks! 💖 Now go ahead and share your first merge with your colleagues, you got yourself this brag right! 😄 🎁

@adswa
Copy link
Contributor

adswa commented Sep 10, 2024

@all-contributors please add @mikapfl for maintenance

Copy link
Contributor

@adswa

I've put up a pull request to add @mikapfl! 🎉

@adswa
Copy link
Contributor

adswa commented Sep 10, 2024

feel free to add yourself to the .zenodo.json file of this repository (second to last position, in front of Michael Hanke), @mikapfl. Alternatively, feel free to leave your details (Name, affiliation, orcid) in a comment and I'll add you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants