Turn the "eternal" handbook date into symbols #1021
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We fix the committer date in the handbook for reasons of reproducibility (no random shasum changes, simply because we execute code at a different time). Hence the dates/times shown do not really make sense (they appear constant, even across multiple steps of a procedure. This appears odd. This changeset replace the timestamps with symbolic placeholders. Their meaning still needs to be described in the intro. Ping #1009
|
The regex does not have the desired effect. Unclear why. |
mslw
reviewed
May 21, 2024
There was a problem hiding this comment.
I think I figured out the regexp @mih (see inline comments), so if you are still interested in having the replacement, then we can go ahead. A TODO from the commit message ("their meaning still needs to be described in the intro") still applies.
FTR, this is what git log run record from 101-101-create looks like in my browser:
Comment on lines
+38
to
+39
| (r'Tue Jun 18 16:13:00 2019 +0000', '🗓🕓'), | ||
| (r'2019-06-18 16:13', '🗓🕓'), |
There was a problem hiding this comment.
I see two reasons why the regexp would not work:
- The plus symbol needs to be escaped (otherwise it's "space, one or more, followed by 0000")
- The time zone can not be taken for granted, the config sets git author & committer date to
2019-06-18T16:13:00, and for me this produces run records with git log sayingTue Jun 18 16:13:00 2019 +0200(I'm in CEST).
I'm also adding a space for IMHO better aesthetics.
Suggested change
| (r'Tue Jun 18 16:13:00 2019 +0000', '🗓🕓'), | |
| (r'2019-06-18 16:13', '🗓🕓'), | |
| (r'Tue Jun 18 16:13:00 2019 \+\d{4}', '🗓 🕓'), | |
| (r'2019-06-18 16:13', '🗓 🕓'), |
Comment on lines
+38
to
+39
| (r'Tue Jun 18 16:13:00 2019 +0000', '🗓🕓'), | ||
| (r'2019-06-18 16:13', '🗓🕓'), |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fix the committer date in the handbook for reasons of reproducibility (no random shasum changes, simply because we execute code at a different time). Hence the dates/times shown do not really make sense (they appear constant, even across multiple steps of a procedure. This appears odd.
This changeset replace the timestamps with symbolic placeholders.
Their meaning still needs to be described in the intro.
Ping #1009