-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setup dependencies + fix YAML bug + fix diagram + fix typo in docstring + tutorial setup #103
Conversation
This introduces changes to the table definition on the database side, and the change won't propagate backward. |
@ttngu207 I would recommend preserving the change at line 310, as it specifically corrects the description (docstring), aligning with the definition already provided at line 332 (model_description). |
model_description
I have reverted one of the changes and updated the title of this minor PR. |
model_description
I have incorporated new modifications into this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MilagrosMarin, thank you for making these changes. It looks like style tests and the test DevContainer builds are failing. Once these are addressed we should be able to finish the review and merge. Let me know if you need any help getting those resolved.
@kushalbakshi I've successfully re-tested the Dev Container, and it built and launched without issues. Additionally, I have also re-tested the tutorial, and it is functioning correctly. However, the |
We cannot merge until at least the style tests have passed, which just requires applying Black formatting to all the files in the repo. I'm not sure what is causing the error with the Also, do you expect the devcontainer build to take 74 minutes? That's how long it is taking before the error occurs. |
My apologies for any confusion earlier. Initially, I misunderstood that the failing style tests and test builds were related to Pytests, not GitHub Action tests. I've taken steps to address the GitHub Action tests by applying Black formatting to specific files, and these changes have resolved the issues. This changes have also optimized the Thank you for your patience and guidance. If there are any further recommendations or specific areas that need attention, please let me know, and I'll promptly address them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @MilagrosMarin. Just needs the CHANGELOG and version.py
updated.
CHANGELOG and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @MilagrosMarin. Thank you for making these changes.
This PR was intended to:
model_description
docstringThis PR has also introduced the following changes:
element-calcium-imaging
dj.config()
for the tutorial / DevContainers is now intutorial_pipeline.py
instead of__init__.py
elements
insetup.py
will now install directly from GitHub instead of PyPI (no longer updated)element-array-ephys
tutorialThis PR also addresses the bug introduced by the latest update to the YAML dependency with the following error emerged in
element_deeplabcut/readers/dlc_reader.py
:AttributeError: safe_load() has been removed, use yaml = YAML(typ= safe , pure=True) yaml.load(...) instead of file /workspaces/element-deeplabcut/element_deeplabcut/readers/dlc_reader.py , line 148 self._yml = yaml.safe_load(f)
By changing it as follows:
yaml_loader = yaml.YAML(typ='safe', pure=True) self._yml = yaml_loader.load(f)
These adjustments, along with the tutorial, have been tested successfully in Codespaces.