Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update React dependency to v18 #19

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Update React dependency to v18 #19

merged 2 commits into from
Dec 12, 2023

Conversation

bindeali
Copy link
Collaborator

@bindeali bindeali commented Nov 29, 2023 •
edited
Loading

@bindeali bindeali requested a review from blcham November 29, 2023 17:04
blcham
blcham approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blcham
Copy link
Collaborator

blcham commented Dec 4, 2023

FYI, termit-ui still uses react 17, so in case we won't need changes to this library, it's ok.

@blcham blcham merged commit a95b017 into main Dec 12, 2023
1 check passed
@blcham blcham deleted the update-react-dependency branch December 12, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blcham blcham blcham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Peer dependency on React does not support 18
2 participants
@bindeali @blcham